[GitHub] sandeep-paliwal commented on a change in pull request #2282: Distributed tracing support #2192

[gi...@git.apache.org]

sandeep-paliwal commented on a change in pull request #2282: Distributed tracing support #2192
URL: https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r120581751
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -12,3 +12,22 @@ akka.http {
         max-open-requests = 128
     }
 }
+
+akka.tracing {
+    #zipkin configuration
+    host = "localhost"
+    host = ${?TRACING_HOST} # Override default HOST by enviornment variable
+    port = 9410 # default
+    port = ${?TRACING_PORT} # Override default PORT by enviornment variable
+    sample-rate = 100 # by default trace every 100th request
 
 Review comment:
   Thanks Adrian for your comment. But I think sample rate in akka-tracing lib is being treated as `int` [(https://github.com/levkhomich/akka-tracing/blob/master/core/src/main/scala/com/github/levkhomich/akka/tracing/TracingExtension.scala#L43)](https://github.com/levkhomich/akka-tracing/blob/master/core/src/main/scala/com/github/levkhomich/akka/tracing/TracingExtension.scala#L43) and does a mod on request counter. 
   ([https://github.com/levkhomich/akka-tracing/blob/master/core/src/main/scala/com/github/levkhomich/akka/tracing/TracingExtension.scala#L324](https://github.com/levkhomich/akka-tracing/blob/master/core/src/main/scala/com/github/levkhomich/akka/tracing/TracingExtension.scala#L324))
   
   So a value between 0 - 1.0 would switch off the tracing.
   I have kept a default of 100 which makes default tracing as 1%.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services