You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "kezhenxu94 (GitHub)" <gi...@apache.org> on 2019/01/10 06:03:24 UTC
[GitHub] [incubator-dubbo] kezhenxu94 commented on issue #3180: fixes
#2999
Reviewers please pay special attention to the method `org.apache.dubbo.registry.redis.RedisRegistry.Notifier#notifyListenersOnJedisInstance`, which is extracted from the original `run` method,
```java
if (first) {
first = false;
Set<String> keys = jedis.keys(service);
if (keys != null && !keys.isEmpty()) {
for (String s : keys) {
doNotify(jedis, s);
}
}
resetSkip();
}
```
the `first` variable is never changed before this patch, if I missed anything, please let me know.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3180 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org