You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/24 00:01:52 UTC
[GitHub] [superset] robdiciuccio opened a new pull request #13759: chore: Add CODEOWNERS for superset/migrations
robdiciuccio opened a new pull request #13759:
URL: https://github.com/apache/superset/pull/13759
### SUMMARY
Per SIP-59 (https://github.com/apache/superset/issues/13351), add `CODEOWNERS` for DB migrations.
_NOTE: this will likely not work due to the GitHub team referenced here not being visible, so I'm opening an INFRA ticket change the team visibility_
### TEST PLAN
Any changes to files under `/superset/migrations/` should notify all committers.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [X] Has associated issue: https://github.com/apache/superset/issues/13351
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sebbASF commented on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
sebbASF commented on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-807657544
Surely changes to files under superset/migrations are already sent to the commits@superset list?
Committers can (should) be subscribed to that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
=======================================
Coverage 77.39% 77.40%
=======================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
=======================================
+ Hits 36521 36522 +1
+ Misses 10523 10522 -1
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+0.01%)` | :arrow_up: |
| hive | `80.24% <ø> (-0.02%)` | :arrow_down: |
| javascript | `63.53% <ø> (ø)` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| python | `80.97% <ø> (ø)` | |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
=======================================
Coverage 77.39% 77.40%
=======================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
=======================================
+ Hits 36521 36522 +1
+ Misses 10523 10522 -1
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.22% -0.17%
==========================================
Files 933 933
Lines 47186 47158 -28
Branches 5872 5872
==========================================
- Hits 36521 36420 -101
- Misses 10523 10596 +73
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.57% <ø> (-0.02%)` | :arrow_down: |
| python | `80.66% <ø> (-0.32%)` | :arrow_down: |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.78% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <0.00%> (-0.42%)` | :arrow_down: |
| [superset/migrations/shared/security\_converge.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy9zaGFyZWQvc2VjdXJpdHlfY29udmVyZ2UucHk=) | `86.82% <0.00%> (-0.11%)` | :arrow_down: |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | `97.82% <0.00%> (-0.05%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.86% <0.00%> (-0.02%)` | :arrow_down: |
| ... and [4 more](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio merged pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
robdiciuccio merged pull request #13759:
URL: https://github.com/apache/superset/pull/13759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.20% -0.19%
==========================================
Files 933 933
Lines 47186 47158 -28
Branches 5872 5872
==========================================
- Hits 36521 36410 -111
- Misses 10523 10606 +83
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.57% <ø> (-0.02%)` | :arrow_down: |
| python | `80.62% <ø> (-0.36%)` | :arrow_down: |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.28% <0.00%> (-0.82%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.78% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.18% <0.00%> (-0.45%)` | :arrow_down: |
| [superset/reports/notifications/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2Jhc2UucHk=) | `95.23% <0.00%> (-0.42%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `1.70%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 75.69% -1.71%
==========================================
Files 933 933
Lines 47186 47185 -1
Branches 5872 5872
==========================================
- Hits 36521 35715 -806
- Misses 10523 11296 +773
- Partials 142 174 +32
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `45.30% <ø> (-10.94%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rontend/src/dashboard/components/dnd/handleDrop.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVEcm9wLmpz) | `0.00% <0.00%> (-96.16%)` | :arrow_down: |
| [...ontend/src/dashboard/components/dnd/handleHover.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9oYW5kbGVIb3Zlci5qcw==) | `11.11% <0.00%> (-88.89%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [...rc/dashboard/components/dnd/dragDroppableConfig.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9kcmFnRHJvcHBhYmxlQ29uZmlnLmpz) | `35.00% <0.00%> (-65.00%)` | :arrow_down: |
| [...c/dashboard/components/dnd/AddSliceDragPreview.jsx](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2RuZC9BZGRTbGljZURyYWdQcmV2aWV3LmpzeA==) | `35.71% <0.00%> (-64.29%)` | :arrow_down: |
| ... and [86 more](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] robdiciuccio commented on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
robdiciuccio commented on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-809626686
@sebbASF The intention here is to automatically add committers as code reviewers to a PR with DB migrations and notify them as such. The high volume on commits@ makes it easy for these changes to be lost in the noise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.24% -0.16%
==========================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
==========================================
- Hits 36521 36447 -74
- Misses 10523 10597 +74
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| python | `80.67% <ø> (-0.30%)` | :arrow_down: |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.78% <0.00%> (-0.49%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.24% -0.16%
==========================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
==========================================
- Hits 36521 36447 -74
- Misses 10523 10597 +74
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.53% <ø> (ø)` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| python | `80.67% <ø> (-0.30%)` | :arrow_down: |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.78% <0.00%> (-0.49%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.21%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.18% -0.22%
==========================================
Files 933 933
Lines 47186 47158 -28
Branches 5872 5872
==========================================
- Hits 36521 36399 -122
- Misses 10523 10617 +94
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.57% <ø> (-0.02%)` | :arrow_down: |
| python | `80.57% <ø> (-0.40%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `90.62% <0.00%> (-6.25%)` | :arrow_down: |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | `86.20% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/models/dashboard.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2Rhc2hib2FyZC5weQ==) | `75.37% <0.00%> (-2.25%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `96.77% <0.00%> (-1.62%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.06% <0.00%> (-1.21%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
=======================================
Coverage 77.39% 77.40%
=======================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
=======================================
+ Hits 36521 36522 +1
+ Misses 10523 10522 -1
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+0.01%)` | :arrow_up: |
| hive | `80.25% <ø> (ø)` | |
| javascript | `63.53% <ø> (ø)` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| python | `80.97% <ø> (ø)` | |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13759: chore: Add CODEOWNERS for superset/migrations
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13759:
URL: https://github.com/apache/superset/pull/13759#issuecomment-805388766
# [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=h1) Report
> Merging [#13759](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=desc) (719b20b) into [master](https://codecov.io/gh/apache/superset/commit/fd7c9eb71e193022816c323eca62564d32fc932a?el=desc) (fd7c9eb) will **decrease** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13759 +/- ##
==========================================
- Coverage 77.39% 77.24% -0.16%
==========================================
Files 933 933
Lines 47186 47186
Branches 5872 5872
==========================================
- Hits 36521 36447 -74
- Misses 10523 10597 +74
Partials 142 142
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.24% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.53% <ø> (ø)` | |
| mysql | `80.56% <ø> (ø)` | |
| postgres | `80.59% <ø> (ø)` | |
| python | `80.67% <ø> (-0.30%)` | :arrow_down: |
| sqlite | `80.15% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-1.05%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.78% <0.00%> (-0.49%)` | :arrow_down: |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/13759/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.42% <0.00%> (+1.51%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=footer). Last update [fd7c9eb...719b20b](https://codecov.io/gh/apache/superset/pull/13759?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org