[jira] Commented: (HADOOP-5574) Separate replication setting out from FSNamesystem

["Suresh Srinivas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-5574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12689559#action_12689559 ] 

Suresh Srinivas commented on HADOOP-5574:
-----------------------------------------

# {{TestReplicationSetting}} - is there a reason to print GOOD IOException? Can it be quietly ignored?
# {{ReplicationSetting}} constructor could use the member vairables instead of defining new variables. Also by making method {{isValid}} final, you could reuse it to check if the {{defaultvalue}} is in the min-max range.
# {{ReplicationSetting.adjust()} the method comment is not very clear as to what adjusted means


> Separate replication setting out from FSNamesystem
> --------------------------------------------------
>
>                 Key: HADOOP-5574
>                 URL: https://issues.apache.org/jira/browse/HADOOP-5574
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: 5574_20090325.patch
>
>
> Replication related setting, included default/min/max replication, etc., deserves a separated class to make the codes in FSNamesystem cleaner.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.