You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/04 04:53:47 UTC

[GitHub] [superset] srinisubramanian opened a new issue, #19502: Export/Import Dashboard does not import chart changes

srinisubramanian opened a new issue, #19502:
URL: https://github.com/apache/superset/issues/19502

   When changes are made to a dashboard and chart(s) and exported and imported the chart changes are not imported.  Only dashboard changes seem to be imported.
   
   #### How to reproduce the bug
   
   Create a dashboard, add a few charts and export (VERSIONED_EXPORT= True).  Import it into another instance for the first time and all changes are imported.
   
   Make some changes to the dashboard AND to the charts.  Export and Import.  The changes to the dashboard are imported but not the changes to the charts.  Some of the changes that were not imported were:
   1.  Pie chart for e.g. Emit Cross Filter
   2. Big Number with trend line - Time filter, changes to filter
   
   ### Expected results
   Chart modifications are also imported
   
   ### Actual results
   Only dashboard changes seem to be imported
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   
   ### Environment
   
   (please complete the following information):
   
   - browser type and version: Chrome
   - superset version: 1.4.1
   - python version: `python --version`
   - node.js version: `node -v`
   - any feature flags active:
   - VERSIONED_EXPORT
   - DASHBOARD_RBAC
   - DASHBOARD_CROSS_FILTER
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinisubramanian commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
srinisubramanian commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1087435815

   @villebro  Request to check if this issue that seems to be fixed in master is to be included in 1.5 as it seems to relate to overall import/export and VERSIONED_EXPORT developments.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] villebro commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1087507415

   AFAIK all PRs that have been merged to master as of this moment related to import/export improvements should be included in 1.5.0rc1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinisubramanian commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
srinisubramanian commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1087325745

   @villebro I know a few issues have been fixed wrt import/export and also planned for 1.5.0 .. can this issue as pointed out by @gbusch  above be looked into?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] gbusch commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
gbusch commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1087320845

   I had the same problem:
   In the file "superset/dashboards/commands/importers/v1/__init__.py" there are calls to functions like import_chart, import_dataset etc. where the parameter "overwrite" is set to False.
   I set them to True and it works. But this is obviously just a hack and requires you to modify the source code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinisubramanian commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
srinisubramanian commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1124477148

   Closing this as a more detailed issues for 1.5.0 is created #20037


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinisubramanian commented on issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
srinisubramanian commented on issue #19502:
URL: https://github.com/apache/superset/issues/19502#issuecomment-1087358862

   Based on the hint above I traced this to superset/charts/commands/importers/v1/utils.py.  Although the API call is passing in overwtite=True, the call always receives False.  Setting it to True in the function imports and overwrites the charts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] srinisubramanian closed issue #19502: Export/Import Dashboard does not import chart changes

Posted by GitBox <gi...@apache.org>.
srinisubramanian closed issue #19502: Export/Import Dashboard does not import chart changes
URL: https://github.com/apache/superset/issues/19502


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org