[GitHub] [incubator-mxnet] zhreshold commented on a change in pull request #14824: Refactor ImageRecordIter

[GitBox <gi...@apache.org>]

zhreshold commented on a change in pull request #14824: Refactor ImageRecordIter
URL: https://github.com/apache/incubator-mxnet/pull/14824#discussion_r280243178
 
 

 ##########
 File path: src/io/iter_image_recordio_2.cc
 ##########
 @@ -133,15 +134,14 @@ inline void ImageRecordIOParser2<DType>::Init(
   record_param_.InitAllowUnknown(kwargs);
   batch_param_.InitAllowUnknown(kwargs);
   normalize_param_.InitAllowUnknown(kwargs);
-  prefetch_param_.InitAllowUnknown(kwargs);
   n_parsed_ = 0;
   overflow = false;
   rnd_.seed(kRandMagic + record_param_.seed);
   int maxthread, threadget;
   #pragma omp parallel
   {
     // be conservative, set number of real cores
-    maxthread = std::max(omp_get_num_procs() / 2 - 1, 1);
+    maxthread = std::max(omp_get_num_procs(), 1);
 
 Review comment:
   Since now the iterator is pushed to engine, will this omp threading make troubles?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services