[GitHub] [hbase] ndimiduk commented on a change in pull request #2087: HBASE-24696 Include JVM information on Web UI under "Software Attributes"

[GitBox <gi...@apache.org>]

ndimiduk commented on a change in pull request #2087:
URL: https://github.com/apache/hbase/pull/2087#discussion_r457732399



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/JvmVersion.java
##########
@@ -44,4 +44,13 @@ public static boolean isBadJvmVersion() {
     String version = System.getProperty("java.version");
     return version != null && BAD_JVM_VERSIONS.contains(version);
   }
+
+  /**
+   * Return the current JVM version information.
+   */
+  public static String getVersion() {

Review comment:
       According to the javadoc in the class header, this is a repurposing of the existing class. I think it's fine to put this method into this class, as the name and location of the class seem like a reasonable place to find this information. Can you update the javadoc on the class header according to the expanded scope of the class?
   
   Otherwise, +1.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org