You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Struberg (JIRA)" <ji...@codehaus.org> on 2011/07/28 23:58:42 UTC

[jira] Created: (MNG-5142) allow static URLSs which don't change in derived submodules

allow static URLSs which don't change in derived submodules
-----------------------------------------------------------

                 Key: MNG-5142
                 URL: https://jira.codehaus.org/browse/MNG-5142
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: Inheritance and Interpolation
    Affects Versions: 3.0.3, 2.2.1
            Reporter: Mark Struberg


In sub-modules, URLs in the MavenModel will automatically get expanded by adding the artifactId of the very sub-module.
This is fine for e.g. a SVN scm URL but breaks other SCMs like git or hg.

Proposal:
We should introduce a 'static:' prefix for URLs which must not get automatically expanded in submodules.
An example:
<scm>
  <developerConnection>static:scm:git:https://myserver.com/gitrepo/... 

The 'static:' info will get removed while parsing the pom.

Compat notes:
I've tried that such scm URLs with mvn-3.0.3 and mvn-2.2.1 in  
<scm><connection>, <developerConnection>, <url>, <distributionManagement><site><url>
and got no error building my project. Of course, if you use the 'static:' prefix then you cannot release or do other site and scm tasks with an old maven version anymore. But that part is considered to be broken anyway at the moment ;)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-5142) allow static URLSs which don't change in derived submodules

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274561#comment-274561 ] 

Mark Struberg commented on MNG-5142:
------------------------------------

another good idea came up. The maven pom XSD does not prevent us from using attributes. So we could just add an 'absolute' attribute to the various url tags. E.g.:

<scm><developerConnection absolute="true">scm:git:https://...

> allow static URLSs which don't change in derived submodules
> -----------------------------------------------------------
>
>                 Key: MNG-5142
>                 URL: https://jira.codehaus.org/browse/MNG-5142
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.2.1, 3.0.3
>            Reporter: Mark Struberg
>
> In sub-modules, URLs in the MavenModel will automatically get expanded by adding the artifactId of the very sub-module.
> This is fine for e.g. a SVN scm URL but breaks other SCMs like git or hg.
> Proposal:
> We should introduce a 'static:' prefix for URLs which must not get automatically expanded in submodules.
> An example:
> <scm>
>   <developerConnection>static:scm:git:https://myserver.com/gitrepo/... 
> The 'static:' info will get removed while parsing the pom.
> Compat notes:
> I've tried that such scm URLs with mvn-3.0.3 and mvn-2.2.1 in  
> <scm><connection>, <developerConnection>, <url>, <distributionManagement><site><url>
> and got no error building my project. Of course, if you use the 'static:' prefix then you cannot release or do other site and scm tasks with an old maven version anymore. But that part is considered to be broken anyway at the moment ;)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-5142) allow static URLSs which don't change in derived submodules

Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274559#comment-274559 ] 

Robert Scholte commented on MNG-5142:
-------------------------------------

{{static:}} sounds a bit confusing, because what would {{dynamic:}} mean?
I'd prefer the usage of {{relative:}} and {{absolute:}} where relative would be the default.
These are well-known terms and immediately clear for everyone.

> allow static URLSs which don't change in derived submodules
> -----------------------------------------------------------
>
>                 Key: MNG-5142
>                 URL: https://jira.codehaus.org/browse/MNG-5142
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.2.1, 3.0.3
>            Reporter: Mark Struberg
>
> In sub-modules, URLs in the MavenModel will automatically get expanded by adding the artifactId of the very sub-module.
> This is fine for e.g. a SVN scm URL but breaks other SCMs like git or hg.
> Proposal:
> We should introduce a 'static:' prefix for URLs which must not get automatically expanded in submodules.
> An example:
> <scm>
>   <developerConnection>static:scm:git:https://myserver.com/gitrepo/... 
> The 'static:' info will get removed while parsing the pom.
> Compat notes:
> I've tried that such scm URLs with mvn-3.0.3 and mvn-2.2.1 in  
> <scm><connection>, <developerConnection>, <url>, <distributionManagement><site><url>
> and got no error building my project. Of course, if you use the 'static:' prefix then you cannot release or do other site and scm tasks with an old maven version anymore. But that part is considered to be broken anyway at the moment ;)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MNG-5142) allow static URLSs which don't change in derived submodules

Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=274621#comment-274621 ] 

Robert Scholte commented on MNG-5142:
-------------------------------------

The {{absolute="true"}} assumes there are only two options: {{absolute}} and {{not absolute}}, which could be {{relative}}. There might be more complex transitions possible, like relative to the parents parent, although this will be a rare case.
Binding it to two states could bring us into trouble in the future.
I'd suggest to use an attribute like {{transition}} or {{location}} with at least support for {{relative}} and {{absolute}}.

> allow static URLSs which don't change in derived submodules
> -----------------------------------------------------------
>
>                 Key: MNG-5142
>                 URL: https://jira.codehaus.org/browse/MNG-5142
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Inheritance and Interpolation
>    Affects Versions: 2.2.1, 3.0.3
>            Reporter: Mark Struberg
>
> In sub-modules, URLs in the MavenModel will automatically get expanded by adding the artifactId of the very sub-module.
> This is fine for e.g. a SVN scm URL but breaks other SCMs like git or hg.
> Proposal:
> We should introduce a 'static:' prefix for URLs which must not get automatically expanded in submodules.
> An example:
> <scm>
>   <developerConnection>static:scm:git:https://myserver.com/gitrepo/... 
> The 'static:' info will get removed while parsing the pom.
> Compat notes:
> I've tried that such scm URLs with mvn-3.0.3 and mvn-2.2.1 in  
> <scm><connection>, <developerConnection>, <url>, <distributionManagement><site><url>
> and got no error building my project. Of course, if you use the 'static:' prefix then you cannot release or do other site and scm tasks with an old maven version anymore. But that part is considered to be broken anyway at the moment ;)

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira