You are viewing a plain text version of this content. The canonical link for it is here.
Posted to modperl-cvs@perl.apache.org by st...@apache.org on 2004/09/29 00:38:46 UTC
cvs commit: modperl-2.0/t/filter both_str_req_proxy.t
stas 2004/09/28 15:38:46
Modified: t/filter both_str_req_proxy.t
Log:
need to use need() if there is more than one skip condition
Revision Changes Path
1.4 +1 -1 modperl-2.0/t/filter/both_str_req_proxy.t
Index: both_str_req_proxy.t
===================================================================
RCS file: /home/cvs/modperl-2.0/t/filter/both_str_req_proxy.t,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -u -r1.3 -r1.4
--- both_str_req_proxy.t 3 Aug 2004 16:16:20 -0000 1.3
+++ both_str_req_proxy.t 28 Sep 2004 22:38:46 -0000 1.4
@@ -5,7 +5,7 @@
use Apache::TestRequest;
use Apache::TestUtil;
-plan tests => 1, (need_module('proxy') && need_access);
+plan tests => 1, need need_module('proxy'), need_access;
my $data = join ' ', 'A'..'Z', 0..9;
my $expected = lc $data; # that's what the input filter does
Re: cvs commit: modperl-2.0/t/filter both_str_req_proxy.t
Posted by Stas Bekman <st...@stason.org>.
Geoffrey Young wrote:
>
> stas@apache.org wrote:
>
>>stas 2004/09/28 15:38:46
>>
>> Modified: t/filter both_str_req_proxy.t
>> Log:
>> need to use need() if there is more than one skip condition
>
>
>> -plan tests => 1, (need_module('proxy') && need_access);
>> +plan tests => 1, need need_module('proxy'), need_access;
>
>
> why is that? I use multiple need_* calls all the time and haven't seen any
> issues.
There are no implications on the test. There are implications for users.
need need_module('proxy'), need_access, ...;
always runs all the requirement checks and reports all the missing
requirements. In the case of:
need_module('proxy') && need_access
if the first requirement fails, the second is not run, and the missing
requirement is not reported. So let's say a user wants to satisy all the
requirements and run the test suite again. If we report all the
requirements right away, he will need to let's say rebuild Apache once, if
we report only one requirement at a time, he will have to rebuild it as
many times as there are && sides...
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: cvs commit: modperl-2.0/t/filter both_str_req_proxy.t
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
stas@apache.org wrote:
> stas 2004/09/28 15:38:46
>
> Modified: t/filter both_str_req_proxy.t
> Log:
> need to use need() if there is more than one skip condition
> -plan tests => 1, (need_module('proxy') && need_access);
> +plan tests => 1, need need_module('proxy'), need_access;
why is that? I use multiple need_* calls all the time and haven't seen any
issues.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org