You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by xuanyuanking <gi...@git.apache.org> on 2018/10/17 15:56:20 UTC

[GitHub] spark pull request #22575: [SPARK-24630][SS] Support SQLStreaming in Spark

Github user xuanyuanking commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22575#discussion_r225992780
  
    --- Diff: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSourceProvider.scala ---
    @@ -63,7 +63,9 @@ private[kafka010] class KafkaSourceProvider extends DataSourceRegister
           providerName: String,
           parameters: Map[String, String]): (String, StructType) = {
         validateStreamOptions(parameters)
    -    require(schema.isEmpty, "Kafka source has a fixed schema and cannot be set with a custom one")
    +    if(schema.isDefined) {
    --- End diff --
    
    Why need this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org