You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by wu...@apache.org on 2021/04/28 09:16:30 UTC

[shardingsphere-elasticjob] branch master updated: fix performance loss for the misfired configuration that is not turned on (#1885)

This is an automated email from the ASF dual-hosted git repository.

wuweijie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere-elasticjob.git


The following commit(s) were added to refs/heads/master by this push:
     new c7a4f1a  fix performance loss for the misfired configuration that is not turned on (#1885)
c7a4f1a is described below

commit c7a4f1ab7eae3ddc5cbb224ca97f2b26c7931bd3
Author: seeger12138 <60...@qq.com>
AuthorDate: Wed Apr 28 17:16:17 2021 +0800

    fix performance loss for the misfired configuration that is not turned on (#1885)
    
    Co-authored-by: xige <121381>
---
 .../shardingsphere/elasticjob/lite/internal/schedule/LiteJobFacade.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/LiteJobFacade.java b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/LiteJobFacade.java
index 6896500..e9b1744 100644
--- a/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/LiteJobFacade.java
+++ b/elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/schedule/LiteJobFacade.java
@@ -131,7 +131,7 @@ public final class LiteJobFacade implements JobFacade {
     
     @Override
     public boolean isExecuteMisfired(final Collection<Integer> shardingItems) {
-        return !isNeedSharding() && configService.load(true).isMisfire() && !executionService.getMisfiredJobItems(shardingItems).isEmpty();
+        return configService.load(true).isMisfire() && !isNeedSharding() && !executionService.getMisfiredJobItems(shardingItems).isEmpty();
     }
     
     @Override