You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 07:17:32 UTC
[GitHub] [airflow] cswpy opened a new pull request, #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
cswpy opened a new pull request, #24363:
URL: https://github.com/apache/airflow/pull/24363
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Fixes: #24160
Modified the unit tests to verify that `create_empty_table` is called at least once.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] alexInhert commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
alexInhert commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895095542
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
importing private function is usually bad practice isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1177586298
Just continue rebasing. It's unlikely broken tests will stay broken for a long time they are usually fixed quickly. You were just unlucky when you hit them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1177107520
Now the PR is failing some checks... I believe this is due to the new commits that has already merged into main, where I rebased my commit onto. Can you advise me on how to proceed? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895880787
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
Seems like https://github.com/apache/airflow/pull/24416/files is changing this function.
so lets wait for this PR to be merged first
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
Seems like https://github.com/apache/airflow/pull/24416 is changing this function.
so lets wait for this PR to be merged first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1159828378
Rebasing is easiest with drop-down next to "Update branch". button. See the instructions on rebase in our CONTRIBUTING docs https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#id14 they have all details @cswpy . The worst case - take your changes and re-apply them manually on top of main if you are somehow lost with your branch. you can start a new PR and close this one - no problem with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24363: Modify BigQueryCreateExternalTableOperator to use updated hook function
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1181634084
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1160114817
The test is failing I am afraid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1159788754
@malthe @eladkal @alexInhert I see that issue #24416 is already merged, can we proceed with this PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #24363: Modify BigQueryCreateExternalTableOperator to use updated hook function
Posted by GitBox <gi...@apache.org>.
eladkal merged PR #24363:
URL: https://github.com/apache/airflow/pull/24363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r896006304
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
Yes, since it is internal function within our repo, it doesn't really matter how we use it. It just means that users should not use the function directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895399684
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
It's in our project. The function is defined in `BigQueryHook`:
https://github.com/apache/airflow/blob/b1ad017cee66f5e042144cc7baa2d44b23b47c4f/airflow/providers/google/cloud/hooks/bigquery.py#L2770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #24363: Modify BigQueryCreateExternalTableOperator to use updated hook function
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1181862998
@cswpy we seem to have another occurrence of the deprecated function
https://github.com/apache/airflow/blob/359dc582078e0d128f42a983c285ffec7ad41686/airflow/providers/google/cloud/transfers/gcs_to_bigquery.py#L256
Would you mind to raise PR for this case as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1152050430
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
eladkal commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1159791851
> @malthe @eladkal @alexInhert I see that issue #24416 is already merged, can we proceed with this PR? Thanks.
Im away from laptop so cant check but if I rember correctly #24416 changed the name of the function that you import so you need to rebase and apply the needed changes herw.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1159807078
I feel like I did something wrong here... not exactly familiar with the workflow to rebase. I first rebased my commit to the latest apache remote branch and then pulled changes from my remote branch, lastly made mods to the PR. Not sure why my code does not pass the up-to-date checker, can anyone advise what to do next? Many thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
eladkal commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895403244
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
I think it's ok. We can use it in the project as we see fit but we basically tell the users don't use the function in custom operators. As for why it's marked private to begin with - I can't tell... I can assume that it's because this is a helper function that takes part in "internal" functionality of operators so the author of the function didn't expect users to use it directly in thier operators.
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
I think it's ok. We can use it in the project as we see fit but we basically tell the users don't use the function in custom operators. As for why it's marked private to begin with - I can't tell... I can assume that it's because this is a helper function that takes part in "internal" functionality of operators so the author of the function didn't expect users to use it directly in their operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1169578804
@eladkal @potiuk I believe the PR is ready to be merged๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1179481361
Hi @potiuk , all checks are passed ๐
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1161730537
Still docs and tests failing. Please fix and rebase it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] malthe commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
malthe commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895114747
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
It might be useful to ask the upstream project why this function is private (in the first place).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1160121293
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1159868872
@potiuk I think it's ready to merge now :) Thanks for the tips.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on a diff in pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on code in PR #24363:
URL: https://github.com/apache/airflow/pull/24363#discussion_r895096606
##########
airflow/providers/google/cloud/operators/bigquery.py:
##########
@@ -36,7 +36,7 @@
from airflow.models import BaseOperator, BaseOperatorLink
from airflow.models.xcom import XCom
from airflow.operators.sql import SQLCheckOperator, SQLIntervalCheckOperator, SQLValueCheckOperator
-from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob
+from airflow.providers.google.cloud.hooks.bigquery import BigQueryHook, BigQueryJob, _split_tablename
Review Comment:
Thanks for the comment. Indeed, private functions are not meant to be imported. But there is no in-class function that could split the table name, which means I either import the private function or rewrite it in the current class. I suppose the former is more acceptable?
Also, I do see that the code imported some other private functions as shown below.
https://github.com/apache/airflow/blob/7fed7f31c3a895c0df08228541f955efb16fbf79/airflow/providers/google/cloud/operators/bigquery.py#L39-L41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1169551841
@potiuk @eladkal I believe this PR is ready to be merged? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] cswpy commented on pull request #24363: Fixed BigQueryCreateExternalTableOperator and its unit test (#24160)
Posted by GitBox <gi...@apache.org>.
cswpy commented on PR #24363:
URL: https://github.com/apache/airflow/pull/24363#issuecomment-1162652544
I fixed the provider tests, but I don't quite understand why it is failing the doc test (the log only has an exit code) and I did not modify any doc-related code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org