You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/19 07:34:26 UTC
[GitHub] [spark] ConeyLiu opened a new pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
ConeyLiu opened a new pull request #31896:
URL: https://github.com/apache/spark/pull/31896
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add the support to submit applications with user-defined cluster manager.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We have supported users to define the customed cluster manager with ExternalClusterManager trait. However, we can not submit the application with SparkSubmit. The reason is that we check the master whether is the natively support one in SparkSubmit. However, the customed cluster manager is checked in SparkContext. So we could not submit applications with
`SparkSubmit` or pyspark on those user-defined cluster managers.
In this patch, we also add a new plugin: `SparkSubmitPlugin` for those users who want to customize their submit environments.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
New UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
mridulm commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-807230547
I agree with @tgravescs, we need to define the contracts more clearly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-802629667
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ConeyLiu commented on pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
ConeyLiu commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-872665406
Hi @tgravescs @mridulm. Sorry for the later response due to some work blocked. Here is the design doc: https://docs.google.com/document/d/1-Sn4Zh-l0SCqH7DQ0esdukS68ptSolK4lStj7MZUqJo/edit?usp=sharing. Please help to review. Thanks a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] closed pull request #31896: [WIP][SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #31896:
URL: https://github.com/apache/spark/pull/31896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] github-actions[bot] commented on pull request #31896: [WIP][SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-945024737
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tgravescs commented on pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
tgravescs commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-804125940
so I would like to see more design details on this. I get that this adds a plugin for spark submit, but there are lots of other code in here that does stuff specific to cluster manager. It also seems to assume that that plugin supports various options. I think we need to clearly define what specifically it will and will not handle and make sure that is documented.
Some basic things are just like does it support both client and cluster deploy modes, which options does it support, how does it deal with dependencies, how does it deal with security, does it work with PySpark, sparkR, spark-shell, spark-submit, etc.
I think to do this properly we would need more APIs between these so it can properly figure out what to do.
kind of minor but I think this should also be referred to as cluster manager plugin or something like that so we know what the plugin is for.
if we are expecting users to implement why is this private[spark]?
private[spark] trait SparkSubmitPlugin
we would want this a developerapi unstable and made public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ConeyLiu commented on pull request #31896: [SPARK-32899][CORE] Support submit application with user-defined cluster manager
Posted by GitBox <gi...@apache.org>.
ConeyLiu commented on pull request #31896:
URL: https://github.com/apache/spark/pull/31896#issuecomment-802620463
cc @tgravescs @KevinSmile who has reviewed the old patch(https://github.com/apache/spark/pull/29770)
And also cc @ericl, pls help to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org