You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2010/04/07 23:27:07 UTC

[jira] Created: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

cppunit test testipv6 assumes that the machine is ipv6 enabled.
---------------------------------------------------------------

                 Key: ZOOKEEPER-735
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
             Project: Zookeeper
          Issue Type: Bug
            Reporter: Mahadev konar
            Assignee: Mahadev konar
             Fix For: 3.3.1, 3.4.0


The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-735:
------------------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

I just committed this to trunk and 3.3 branch.

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: ZOOKEEPER-735.patch
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854764#action_12854764 ] 

Hadoop QA commented on ZOOKEEPER-735:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12441097/ZOOKEEPER-735.patch
  against trunk revision 929564.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 5 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/48/console

This message is automatically generated.

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: ZOOKEEPER-735.patch
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-735:
------------------------------------

    Status: Patch Available  (was: Open)

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: ZOOKEEPER-735.patch
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854821#action_12854821 ] 

Patrick Hunt commented on ZOOKEEPER-735:
----------------------------------------

+1, looks good to me. I was able to run configure on cygwin 1.5 and it detected that there was no ipv6 (is none).
Ran on my ubuntu system and detected that there was ipv6.

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: ZOOKEEPER-735.patch
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-735:
------------------------------------

    Attachment: ZOOKEEPER-735.patch

this patch fixes the issue. I have tested it on ipv6/ipv4 redhat/ubuntu machines. The patch seems pretty general to be working on other platforms. Do give it a try if you have a different platform.

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>         Attachments: ZOOKEEPER-735.patch
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-735) cppunit test testipv6 assumes that the machine is ipv6 enabled.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-735:
------------------------------------

    Component/s: tests

> cppunit test testipv6 assumes that the machine is ipv6 enabled.
> ---------------------------------------------------------------
>
>                 Key: ZOOKEEPER-735
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-735
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: tests
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.3.1, 3.4.0
>
>
> The test should be fixed so that it runs only if ipv6 is enabled and does not run if ipv6 is not enabled.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.