You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/04/15 04:00:58 UTC

[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3207: Fix testCompactionPersistence do not cleanup created directory

hangc0276 opened a new pull request, #3207:
URL: https://github.com/apache/bookkeeper/pull/3207

   ### Motivation
   In `CompactionTest.testCompactionPersistence()`, it specified a directory as rocksdb storage path, but does't clean up it when the test finished.
   https://github.com/apache/bookkeeper/blob/e937ae9a6838fd533c3973d6ae6c32d98b6619bd/bookkeeper-server/src/test/java/org/apache/bookkeeper/bookie/CompactionTest.java#L1011-L1012
   
   
   ### Changes
   Use tmpDir to manage the created directory and clean up the resources when test finished.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 commented on pull request #3207: Fix testCompactionPersistence do not cleanup created directory

Posted by GitBox <gi...@apache.org>.
hangc0276 commented on PR #3207:
URL: https://github.com/apache/bookkeeper/pull/3207#issuecomment-1099841749

   rerun failure checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] eolivelli merged pull request #3207: Fix testCompactionPersistence do not cleanup created directory

Posted by GitBox <gi...@apache.org>.
eolivelli merged PR #3207:
URL: https://github.com/apache/bookkeeper/pull/3207


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org