[GitHub] [sling-maven-plugin] stefanseifert commented on a diff in pull request #16: SLING-11543 improve exception handling for invalid bundle files

[GitBox <gi...@apache.org>]

stefanseifert commented on code in PR #16:
URL: https://github.com/apache/sling-maven-plugin/pull/16#discussion_r946686737


##########
src/main/java/org/apache/sling/maven/bundlesupport/BundleInstallMojo.java:
##########
@@ -65,7 +65,7 @@ protected File getBundleFileName() {
                 getLog().debug("No bundle found in secondary artifact " + file);
             }
         }
-        return null;
+        throw new MojoExecutionException("No attached bundle found for this Maven project, for standalone usage use goal 'install-file' instead!");

Review Comment:
   with this explicit error message it's fine in my pov.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org