You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/30 19:53:55 UTC

Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63428/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Benno Evers, Gaston Kleiman, and Jiang Yan Xu.


Bugs: MESOS-8136
    https://issues.apache.org/jira/browse/MESOS-8136


Repository: mesos


Description
-------

Updated the XFS disk isolator tests to handle the new TASK_STARTING
status update from the Mesos executors.


Diffs
-----

  src/tests/containerizer/xfs_quota_tests.cpp 460384736a19eceb0e61b3d414c23cd545f8600e 


Diff: https://reviews.apache.org/r/63428/diff/1/


Testing
-------

sudo make check (Fedora 26)


Thanks,

James Peach


Re: Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63428/#review189704
-----------------------------------------------------------



PASS: Mesos patch 63428 was successfully built and tested.

Reviews applied: `['63428']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63428

- Mesos Reviewbot Windows


On Oct. 30, 2017, 7:53 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63428/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benno Evers, Gaston Kleiman, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8136
>     https://issues.apache.org/jira/browse/MESOS-8136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the XFS disk isolator tests to handle the new TASK_STARTING
> status update from the Mesos executors.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 460384736a19eceb0e61b3d414c23cd545f8600e 
> 
> 
> Diff: https://reviews.apache.org/r/63428/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63428/#review189668
-----------------------------------------------------------


Ship it!




- Gaston Kleiman


On Oct. 30, 2017, 12:53 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63428/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 12:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benno Evers, Gaston Kleiman, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8136
>     https://issues.apache.org/jira/browse/MESOS-8136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the XFS disk isolator tests to handle the new TASK_STARTING
> status update from the Mesos executors.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 460384736a19eceb0e61b3d414c23cd545f8600e 
> 
> 
> Diff: https://reviews.apache.org/r/63428/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Re: Review Request 63428: Updated XFS tests to handle the TASK_STARTING state.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63428/#review189702
-----------------------------------------------------------



Patch looks great!

Reviews applied: [63428]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Oct. 30, 2017, 7:53 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63428/
> -----------------------------------------------------------
> 
> (Updated Oct. 30, 2017, 7:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benno Evers, Gaston Kleiman, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-8136
>     https://issues.apache.org/jira/browse/MESOS-8136
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the XFS disk isolator tests to handle the new TASK_STARTING
> status update from the Mesos executors.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/xfs_quota_tests.cpp 460384736a19eceb0e61b3d414c23cd545f8600e 
> 
> 
> Diff: https://reviews.apache.org/r/63428/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>