You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/03/30 16:50:48 UTC

[GitHub] [myfaces] melloware opened a new pull request #191: MYFACES-4390: HtmlInputFile multiple support

melloware opened a new pull request #191:
URL: https://github.com/apache/myfaces/pull/191


   I feel like an alien in this code base!
   
   I didn't see any existing tests to update so i wasn't even sure where to begin to add a test for this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware edited a comment on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware edited a comment on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810434911


   Also there were some warnings from IntelliJ about some evaluations ALWAYS being true etc but I did not fix any of them only touched the bare minimum to add this feature.
   
   ![image](https://user-images.githubusercontent.com/4399574/113040975-6bbadf00-9167-11eb-9a5c-bd68cd6e4b88.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] GedMarc commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
GedMarc commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810982715


   yeah disabled=true doesn't work across all browsers, has to be  just "disabled" or "disabled=disabled"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] tandraschko commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810818644


   why not
   ```writer.writeAttribute(HTML.MULTIPLE_ATTR, "multiple", null);``` then?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-811018875


   Yep will do!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810981894


   OK I updated it. to write out "multiple" but what threw me off is the lines above it were this...
   ```java
   if (inputFile.isDisabled())
   {
        writer.writeAttribute(HTML.DISABLED_ATTR, Boolean.TRUE, null);
   }
   ```
   
   But in PrimeFaces code we do this...
   ```java
    writer.writeAttribute("disabled", "disabled", null);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] tandraschko merged pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
tandraschko merged pull request #191:
URL: https://github.com/apache/myfaces/pull/191


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] GedMarc commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
GedMarc commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810983661


   ref here https://stackoverflow.com/questions/6961526/what-is-the-correct-value-for-the-disabled-attribute
   
   Don't use attributes=true for these at all, ever


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware edited a comment on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware edited a comment on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810437136


   Also unsure as its mentioned it should render `multiple="multiple"` but right now I think it would render `multiple="true"`.  I still think `multiple="true"` is OK.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] tandraschko commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
tandraschko commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810998847


   @melloware would you please add a jira issue and provide a PR? would be great!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] GedMarc edited a comment on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
GedMarc edited a comment on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810982715


   yeah disabled=true doesn't work across all browsers, has to be  just "disabled" or "disabled=disabled",
   
   Multiple is the same, cant be multiple=true, must be multiple=multiple, or just "multiple"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810434911


   Also there were some warnings from IntelliJ about some evaluations ALWAYS being true etc but I did not fix any of them only touched the bare minimum to add this feature.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810984037


   Thanks @GedMarc. So @tandraschko so then the Disabled attribute here is incorrect then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [myfaces] melloware commented on pull request #191: MYFACES-4390: HtmlInputFile multiple support

Posted by GitBox <gi...@apache.org>.
melloware commented on pull request #191:
URL: https://github.com/apache/myfaces/pull/191#issuecomment-810437136


   Also unsure as its mentioned it should render `multiple="multiple"` but right now I think it would render `multiple="true"`.  Wasn't sure how to do that in MyFaces with JSFProperty.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org