You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/29 00:12:29 UTC

[GitHub] [arrow] kou commented on a change in pull request #8289: ARROW-10116: [Python][Packaging] Fix gRPC linking error in macOS wheels builds

kou commented on a change in pull request #8289:
URL: https://github.com/apache/arrow/pull/8289#discussion_r496302896



##########
File path: cpp/src/arrow/flight/CMakeLists.txt
##########
@@ -24,6 +24,10 @@ set(ARROW_FLIGHT_STATIC_LINK_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF} gRPC::grpc++ c-a
 
 if(WIN32)
   list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ws2_32.lib)
+elseif(APPLE)
+  if(LIBRESOLV_LIBRARY)
+    list(APPEND ARROW_FLIGHT_STATIC_LINK_LIBS ${LIBRESOLV_LIBRARY})
+  endif()

Review comment:
       Can we use `set_target_properties(c-ares::cares PROPERTIES INTERFACE_LINK_LIBRARIES "${LIBRESOLV_LIBRARY}")` instead of this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org