You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2026/04/08 03:34:45 UTC
[PR] KAFKA-20307: expose header-stores natively in IQv1 [kafka]
mjsax opened a new pull request, #21992:
URL: https://github.com/apache/kafka/pull/21992
We previously only added support to query headers stores as plain- or ts-kv-stores. This PR exposes headers-store with their native type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20307: expose header-stores natively in IQv1 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #21992:
URL: https://github.com/apache/kafka/pull/21992#issuecomment-4207858400
Merged to `trunk` and cherry-picked to `4.3` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20307: expose header-stores natively in IQv1 [kafka]
Posted by "bbejeck (via GitHub)" <gi...@apache.org>.
bbejeck commented on code in PR #21992:
URL: https://github.com/apache/kafka/pull/21992#discussion_r3051458264
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java:
##########
@@ -2018,51 +1981,4 @@ public void process(final Record<String, String> record) {
}
}
- // ==================== Custom QueryableStoreTypes ====================
Review Comment:
Why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20307: expose header-stores natively in IQv1 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #21992:
URL: https://github.com/apache/kafka/pull/21992#discussion_r3052759956
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java:
##########
@@ -2018,51 +1981,4 @@ public void process(final Record<String, String> record) {
}
}
- // ==================== Custom QueryableStoreTypes ====================
Review Comment:
Because we don't need it any longer. We only needed to add it, because we did not have `QueryableStoreTypes.TimestampedKeyValueStoreWithHeadersType` yet.
So all calls to `new TimestampedKeyValueStoreWithHeadersType` can be replaced with `QueryableStoreTypes.timestampedWindowStoreWithHeaders()` to use the built-in functionality of KS now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20307: expose header-stores natively in IQv1 [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #21992:
URL: https://github.com/apache/kafka/pull/21992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org