You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/08/08 17:11:18 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #27867: Create MemoryMonitorOptions class for GC thrashing parameter

Abacn commented on code in PR #27867:
URL: https://github.com/apache/beam/pull/27867#discussion_r1287426805


##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowPipelineOptions.java:
##########
@@ -53,7 +54,8 @@ public interface DataflowPipelineOptions
         StreamingOptions,
         DataflowWorkerLoggingOptions,
         DataflowProfilingOptions,
-        PubsubOptions {
+        PubsubOptions,
+        MemoryMonitorOptions {

Review Comment:
   DataflowPipelineOptions extends DataflowPipelineDebugOptions extends DataflowPipelineDebugOptions. Is MemoryMonitorOptions also needed here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org