You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by yi...@apache.org on 2024/01/25 05:25:50 UTC
(doris) 35/37: [bugfix](core) fix core due to send rpc and request is deconstructed (#30344)
This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 6614d40dadf89d5a204c27d318b74f2db9afaf19
Author: yiguolei <67...@qq.com>
AuthorDate: Thu Jan 25 12:28:59 2024 +0800
[bugfix](core) fix core due to send rpc and request is deconstructed (#30344)
Co-authored-by: yiguolei <yi...@gmail.com>
---
be/src/pipeline/exec/exchange_sink_buffer.cpp | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/be/src/pipeline/exec/exchange_sink_buffer.cpp b/be/src/pipeline/exec/exchange_sink_buffer.cpp
index 9d240945be1..2ea8f6e576e 100644
--- a/be/src/pipeline/exec/exchange_sink_buffer.cpp
+++ b/be/src/pipeline/exec/exchange_sink_buffer.cpp
@@ -100,9 +100,12 @@ ExchangeSinkBuffer<Parent>::~ExchangeSinkBuffer() = default;
template <typename Parent>
void ExchangeSinkBuffer<Parent>::close() {
- _instance_to_broadcast_package_queue.clear();
- _instance_to_package_queue.clear();
- _instance_to_request.clear();
+ // Could not clear the queue here, because there maybe a running rpc want to
+ // get a request from the queue, and clear method will release the request
+ // and it will core.
+ //_instance_to_broadcast_package_queue.clear();
+ //_instance_to_package_queue.clear();
+ //_instance_to_request.clear();
}
template <typename Parent>
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org