You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "zwoop (via GitHub)" <gi...@apache.org> on 2026/07/24 21:42:52 UTC
[PR] header_rewrite: reject bad run-plugin at config load [trafficserver]
zwoop opened a new pull request, #13425:
URL: https://github.com/apache/trafficserver/pull/13425
A run-plugin whose target plugin failed to load left a null instance that tripped a release assert and aborted the server on the first request. Propagate the load failure as an exception so the rule is rejected at config load time (a reload simply keeps the running config), and guard exec() so a stray bad rule can never abort the process.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] header_rewrite: reject bad run-plugin at config load [trafficserver]
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #13425:
URL: https://github.com/apache/trafficserver/pull/13425#discussion_r3661313573
##########
plugins/header_rewrite/operators.cc:
##########
@@ -1282,8 +1283,7 @@ OperatorRunPlugin::initialize(Parser &p)
auto plugin_args = p.get_value();
if (plugin_name.empty()) {
- TSError("[%s] missing plugin name", PLUGIN_NAME);
- return;
+ throw std::runtime_error("run-plugin missing plugin name");
Review Comment:
Did Claude do this? We typically don't throw exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] header_rewrite: reject bad run-plugin at config load [trafficserver]
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #13425:
URL: https://github.com/apache/trafficserver/pull/13425#issuecomment-5074759350
[approve ci]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] header_rewrite: reject bad run-plugin at config load [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt commented on PR #13425:
URL: https://github.com/apache/trafficserver/pull/13425#issuecomment-5184995147
Superseded by #13493, which takes over this change with Leif's original authored commit and message preserved, applies the review feedback, and avoids the new exception path. Thanks, Leif!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] header_rewrite: reject bad run-plugin at config load [trafficserver]
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt closed pull request #13425: header_rewrite: reject bad run-plugin at config load
URL: https://github.com/apache/trafficserver/pull/13425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org