You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/24 17:07:38 UTC
Review Request 55884: Updated the naming of unacknowledged tasks in
executors for clarity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/launcher/default_executor.cpp a03794934adb93868734f8cf00b337a1bff9b5ab
src/launcher/executor.cpp f0127f655afa8f696f7a63740d73129f997cbd22
Diff: https://reviews.apache.org/r/55884/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55884: Updated the naming of unacknowledged tasks
in executors for clarity.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/#review162911
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55884]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 24, 2017, 5:07 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55884/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 5:07 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp a03794934adb93868734f8cf00b337a1bff9b5ab
> src/launcher/executor.cpp f0127f655afa8f696f7a63740d73129f997cbd22
>
> Diff: https://reviews.apache.org/r/55884/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55884: Updated the naming of unacknowledged tasks
in executors for clarity.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/#review163274
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55884]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 27, 2017, 12:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55884/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:10 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
>
> Diff: https://reviews.apache.org/r/55884/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55884: Updated the naming of unacknowledged tasks
in executors for clarity.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/#review163378
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 27, 2017, 12:10 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55884/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2017, 12:10 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
> src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
>
> Diff: https://reviews.apache.org/r/55884/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55884: Updated the naming of unacknowledged tasks
in executors for clarity.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/
-----------------------------------------------------------
(Updated Jan. 27, 2017, 12:10 p.m.)
Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/launcher/default_executor.cpp 97eee05cac8cb1f62d43e2aecc08a8e54e49eac3
src/launcher/executor.cpp 0c770bb18ae8bd8df85589b5262f457ab50574a9
Diff: https://reviews.apache.org/r/55884/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55884: Updated the naming of unacknowledged tasks
in executors for clarity.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55884/#review162874
-----------------------------------------------------------
src/launcher/default_executor.cpp (line 1016)
<https://reviews.apache.org/r/55884/#comment234239>
do you want to rename this to `unacknowledgedUpdates` as well for consistency?
src/launcher/executor.cpp (line 799)
<https://reviews.apache.org/r/55884/#comment234240>
ditto. rename?
- Vinod Kone
On Jan. 24, 2017, 5:07 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55884/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2017, 5:07 p.m.)
>
>
> Review request for mesos, Anand Mazumdar, Gast�n Kleiman, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/launcher/default_executor.cpp a03794934adb93868734f8cf00b337a1bff9b5ab
> src/launcher/executor.cpp f0127f655afa8f696f7a63740d73129f997cbd22
>
> Diff: https://reviews.apache.org/r/55884/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>