[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #8246: [To rel/1.0] Add CUSTOM policy for schema region group

[GitBox <gi...@apache.org>]

CRZbulabula commented on code in PR #8246:
URL: https://github.com/apache/iotdb/pull/8246#discussion_r1034658854


##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/partition/IoTDBCustomRegionGroupExtensionIT.java:
##########
@@ -88,6 +92,12 @@ public void setUp() throws Exception {
 
     originalTimePartitionInterval = CONF.getTimePartitionInterval();
 
+    originalSchemaRegionGroupExtensionPolicy = CONF.getSchemaRegionGroupExtensionPolicy();
+    CONF.setSchemaRegionGroupExtensionPolicy(testSchemaRegionGroupExtensionPolicy);
+
+    originalSchemaRegionGroupPerDatabase = CONF.getSchemaRegionGroupPerDatabase();
+    CONF.setSchemaRegionGroupPerDatabase(testSchemaRegionGroupPerDatabase);

Review Comment:
   Need to add ClusterIT for these to parameters



##########
node-commons/src/assembly/resources/conf/iotdb-common.properties:
##########
@@ -84,6 +84,18 @@
 # Datatype: Double
 # schema_region_per_data_node=1.0
 
+# The policy of extension SchemaRegionGroup for each Database.
+# These policies are currently supported:
+# 1. CUSTOM(Each Database will allocate schema_region_group_per_database RegionGroups as soon as created)
+# 2. AUTO(Each Database will automatically extend SchemaRegionGroups based on the data it has)
+# Datatype: String
+# schema_region_group_extension_policy=AUTO

Review Comment:
   Will it be better if we move the parameter `schema_region_group_extension_policy` ahead of the `schema_region_per_data_node`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org