[GitHub] [druid] jnaous commented on issue #9092: Fix deserialization of maxBytesInMemory

[GitBox <gi...@apache.org>]

jnaous commented on issue #9092: Fix deserialization of maxBytesInMemory
URL: https://github.com/apache/druid/pull/9092#issuecomment-568583566
 
 
   Would it be possible to add a unit test for this? Thanks!
   
   On Mon, Dec 23, 2019 at 1:08 PM Atul Mohan <no...@github.com> wrote:
   
   > The maxBytesInMemory property within realtime tuning config isn't
   > presently deserializable and as a result, realtime ingestion task logs do
   > not display this property within the ingestion spec. This PR fixes the
   > issue.
   >
   > This PR has:
   >
   >    - been self-reviewed.
   >    - been tested in a test Druid cluster.
   >
   > ------------------------------
   > You can view, comment on, or merge this pull request online at:
   >
   >   https://github.com/apache/druid/pull/9092
   > Commit Summary
   >
   >    - Fix deserialization of maxBytesInMemory
   >
   > File Changes
   >
   >    - *M*
   >    indexing-service/src/main/java/org/apache/druid/indexing/common/index/RealtimeAppenderatorTuningConfig.java
   >    <https://github.com/apache/druid/pull/9092/files#diff-0> (1)
   >    - *M*
   >    server/src/main/java/org/apache/druid/segment/indexing/RealtimeTuningConfig.java
   >    <https://github.com/apache/druid/pull/9092/files#diff-1> (1)
   >
   > Patch Links:
   >
   >    - https://github.com/apache/druid/pull/9092.patch
   >    - https://github.com/apache/druid/pull/9092.diff
   >
   > —
   > You are receiving this because you are subscribed to this thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/druid/pull/9092?email_source=notifications&email_token=AAPSYCX4EZEUR3RG4W6OHCTQ2ESFXA5CNFSM4J6YCOTKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ICMZNNA>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAPSYCVRA5YNXXARLRM4F43Q2ESFXANCNFSM4J6YCOTA>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org