You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/28 11:49:16 UTC
[GitHub] [incubator-nuttx-apps] pkarashchenko opened a new pull request #989: examples/lvgldemo: bugfix typos and enable GRAPHICS_LVGL
pkarashchenko opened a new pull request #989:
URL: https://github.com/apache/incubator-nuttx-apps/pull/989
## Summary
- Typos detected and fixed.
- Enable `GRAPHICS_LVGL` when `EXAMPLES_LVGLDEMO` is enabled. Otherwise compilation fails
## Impact
None
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #989: examples/lvgldemo: bugfix typos and enable GRAPHICS_LVGL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #989:
URL: https://github.com/apache/incubator-nuttx-apps/pull/989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #989: examples/lvgldemo: bugfix typos and enable GRAPHICS_LVGL
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #989:
URL: https://github.com/apache/incubator-nuttx-apps/pull/989#discussion_r794504249
##########
File path: examples/lvgldemo/Kconfig
##########
@@ -6,6 +6,7 @@
menuconfig EXAMPLES_LVGLDEMO
tristate "LVGL Demo"
default n
+ select GRAPHICS_LVGL
Review comment:
I was thinking of that. Let me explore the code and find similar example, so I can probably do it in a same style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #989: examples/lvgldemo: bugfix typos and enable GRAPHICS_LVGL
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #989:
URL: https://github.com/apache/incubator-nuttx-apps/pull/989#discussion_r794451379
##########
File path: examples/lvgldemo/Kconfig
##########
@@ -6,6 +6,7 @@
menuconfig EXAMPLES_LVGLDEMO
tristate "LVGL Demo"
default n
+ select GRAPHICS_LVGL
Review comment:
should we depends on GRAPHICS_LVGL?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #989: examples/lvgldemo: bugfix typos and enable GRAPHICS_LVGL
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #989:
URL: https://github.com/apache/incubator-nuttx-apps/pull/989#discussion_r794553724
##########
File path: examples/lvgldemo/Kconfig
##########
@@ -6,6 +6,7 @@
menuconfig EXAMPLES_LVGLDEMO
tristate "LVGL Demo"
default n
+ select GRAPHICS_LVGL
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org