[GitHub] [tvm] gromero opened a new pull request #10865: [TVMC] tune: Check if FILE exists (#10608)

[GitBox <gi...@apache.org>]

gromero opened a new pull request #10865:
URL: https://github.com/apache/tvm/pull/10865


   Currently when a non-existing FILE is passed to 'tvmc tune' it throws
   a traceback because a FileNotFoundError exception is not handled. Since
   there is no need for such abrupt exit, and the trace can also confuse
   users, this commit fixes it by checking if FILE indeed exists, kindly
   informing the user about the non-existing FILE before exiting.
   
   Signed-off-by: Gustavo Romero <gu...@linaro.org>
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on a change in pull request #10865: [TVMC] tune: Check if FILE exists (#10608)

[GitBox <gi...@apache.org>]

Mousius commented on a change in pull request #10865:
URL: https://github.com/apache/tvm/pull/10865#discussion_r840669141



##########
File path: python/tvm/driver/tvmc/autotuner.py
##########
@@ -233,6 +233,11 @@ def drive_tune(args):
     args: argparse.Namespace
         Arguments from command line parser.
     """
+    if not os.path.isfile(args.FILE):

Review comment:
       Is it possible to add a unit test for this? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org