You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/01 23:39:23 UTC
[GitHub] [geode] dschneider-pivotal opened a new pull request #5193: GEODE-8211: fix flaky ShutdownIntegrationTest
dschneider-pivotal opened a new pull request #5193:
URL: https://github.com/apache/geode/pull/5193
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] dschneider-pivotal merged pull request #5193: GEODE-8211: fix flaky ShutdownIntegrationTest
Posted by GitBox <gi...@apache.org>.
dschneider-pivotal merged pull request #5193:
URL: https://github.com/apache/geode/pull/5193
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] gesterzhou commented on a change in pull request #5193: GEODE-8211: fix flaky ShutdownIntegrationTest
Posted by GitBox <gi...@apache.org>.
gesterzhou commented on a change in pull request #5193:
URL: https://github.com/apache/geode/pull/5193#discussion_r433551229
##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java
##########
@@ -61,7 +61,11 @@ public void shutdownIsDisabled_whenOnlySupportedCommandsAreAllowed() {
// Unfortunately Jedis' shutdown() doesn't seem to throw a JedisDataException when the command
// returns an error.
- jedis.shutdown();
+ try {
+ jedis.shutdown();
+ } catch (JedisConnectionException ignore) {
+ // Sometimes it throws sometimes it does not.
+ }
Review comment:
You might need to fix line 70 too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org