[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #148: replace use of unmaintained setup-scala action

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098566736


##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
 name: Scalafmt
 
-permissions: read-all
+permissions: {}

Review Comment:
   I don't think read-all is needed. `{}` disables the jobs access to repository secrets - and this should be the go-to setting unless a job needs to read secrets



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org