You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by joey001 <gi...@git.apache.org> on 2015/05/04 22:54:28 UTC
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
GitHub user joey001 opened a pull request:
https://github.com/apache/flink/pull/649
[FLINK-1707][WIP]Add an Affinity Propagation Library Method
I just finished the initial version of AP implementation and pass some preliminary test. The input of the program include two files:
1 similarity graph : each line indicates the similarity between two vertices. if <v1, v2, simi> exists, the user is obligatory to ensure the existence of <v2,v1, simi>. I am considering validating the graph before run the algorithm.
2 vertex preference: each line indicates the preference of each vertex.
The outputs format is : <vertexId, exemplarId>, indicating the id of the vertex and the id of its exemplar.
In the value of each vertex, there is a hashmap storing all the similarities, responsibilities,availabilities to all its neighbor vertex. There are updated in the vertex centric iteration.
I still do some test and verification? Any advices?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joey001/flink ap_add
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/649.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #649
----
commit 240d6f68505bac25db90962dc510221badc4dba4
Author: joey001 <zh...@gmail.com>
Date: 2015-05-04T20:40:16Z
add init implementation of affinity appropagation
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-101989242
@joey001,
How did you rebase this? It should not normally contain everyone's commits... Right now it looks like 18 people participated in the implementation of Affinity Propagation :)
Also a common practice is to write a "PR updated" comment after adding something to your pull request. That way people will be notified and will review your changes asap. If you don't comment, you run the risk of having your PR hang in here longer ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by joey001 <gi...@git.apache.org>.
Github user joey001 commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-129225364
@vasia
It turns out that I don't have enough time and energy for this problem. I will close the PR and hope the code will at least benefit the future followers. Very nice to cooperate with you even a short period and know such a wonderful project!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-129226226
Thanks for the fast response and your kind words :)
Glad to have collaborated with you, too!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-108284020
Hey @joey001!
Are you still working on this? Let us know if you need help!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-98983169
For the test: did you have a look at the other Gelly tests(https://github.com/apache/flink/tree/master/flink-staging/flink-gelly/src/test/java/org/apache/flink/graph/test/example)? They are pretty easy to follow.
Unless your algorithm gives non-deterministic results. Is this the case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-108431985
For 1, I would open a fresh PR, I guess this is too messy to try to fix.
Normally, you should:
change to master
git remote -v
pull the latest state - git pull upstream master
and then change back to your branch
git rebase master
then when pushing
git push -f origin <branch-name>
For 3. Open the new PR and we will have a look at the current solution :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by vasia <gi...@git.apache.org>.
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-129223427
Hi @joey001,
any news regarding this PR? If you have no time to work on this, that's fine! You can close the PR and someone will hopefully pick up the issue. Just let us know :)
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by joey001 <gi...@git.apache.org>.
Github user joey001 closed the pull request at:
https://github.com/apache/flink/pull/649
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by andralungu <gi...@git.apache.org>.
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-108364900
Hi @vasia ,
I believe the problem @joey001 had was that in one of the test modes, he got the classical "Too few memory segments provided. You need at least 33 segments, etc". As far as I remember, @StephanEwen said there is ongoing work in that direction. We probably cannot merge anything with failing tests anyway :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-1707][WIP]Add an Affinity Propagation L...
Posted by joey001 <gi...@git.apache.org>.
Github user joey001 commented on the pull request:
https://github.com/apache/flink/pull/649#issuecomment-108422058
Hello, i will submit a right version of AP algorithm in this ASAP. I am so occupied by two urgent papers unfortunately. Now, I mainly have 3 questions for the work.
1,The first is how to rebase the branch, as commented by andralungu , i must merge the work in a wrong way. I am now confused by the my git. i was considering do open a brand new branch for committing?
2. The other one is "Too few memory segments provided". As @andralungu said, It sames that the problem couldn't be solved immediately?
3. In AP algorithm in the original paper, normal distributed small values are added to the weights of edges to remove degeneracies, however, the generation of normal distribution data is not supported yet. Currently, all the current test are passed, but i guess it's still a problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---