[GitHub] [spark] HeartSaVioR commented on a change in pull request #31593: [SPARK-34473][SQL] Avoid NPE in DataFrameReader.schema(StructType)

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #31593:
URL: https://github.com/apache/spark/pull/31593#discussion_r579584803



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala
##########
@@ -73,8 +73,10 @@ class DataFrameReader private[sql](sparkSession: SparkSession) extends Logging {
    * @since 1.4.0
    */
   def schema(schema: StructType): DataFrameReader = {
-    val replaced = CharVarcharUtils.failIfHasCharVarchar(schema).asInstanceOf[StructType]
-    this.userSpecifiedSchema = Option(replaced)
+    if (schema != null) {

Review comment:
       I'd also prefer not allowing null, but no strong voice.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org