You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Greg Solovyev (Code Review)" <ge...@cloudera.org> on 2018/08/23 22:40:13 UTC

[kudu-CR] Add protobuf generated files to Eclipse project classpath. 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/11310

to review the following change.


Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Java projects and allows to can run JUnit tests from Eclipse.

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 13 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 1
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11310

to look at the new patch set (#5).

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Kudu Java projects
and can run JUnit tests directly

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/5
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 27 Aug 2018 18:16:21 +0000
Gerrit-HasComments: No

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle
File java/gradle/protobuf.gradle:

http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@41
PS2, Line 41:            entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java".replace("${project.projectDir}",""), null)
> Split this line up and maybe add a comment explaining what 'null' is, and w
Why is the replace needed here?



-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 23:31:52 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11310

to look at the new patch set (#4).

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Kudu Java projects
and can run JUnit tests directly

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 20 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/4
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 4
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11310

to look at the new patch set (#3).

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Kudu Java projects
and can run JUnit tests directly

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 19 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/3
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/11310/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/11310/2//COMMIT_MSG@9
PS2, Line 9: With this change Eclipse can compile all Java projects
           : and allows to can run JUnit tests from Eclipse.
Maybe reword as: "With this change Eclipse can compile all Kudu Java projects and can run JUnit tests directly"?


http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle
File java/gradle/protobuf.gradle:

http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@38
PS2, Line 38:     classpath {
Nit: wrong indentation here?


http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@41
PS2, Line 41:            entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java".replace("${project.projectDir}",""), null)
Split this line up and maybe add a comment explaining what 'null' is, and what replace() accomplishes? Also separate the two operands in replace() with a space after the comma.



-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 23 Aug 2018 22:47:29 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle
File java/gradle/protobuf.gradle:

http://gerrit.cloudera.org:8080/#/c/11310/2/java/gradle/protobuf.gradle@41
PS2, Line 41:            entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java".replace("${project.projectDir}",""), null)
> Why is the replace needed here?
I am still curious why the replace is needed to relativize this path?



-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 24 Aug 2018 20:04:48 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Kudu Java projects
and can run JUnit tests directly

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Reviewed-on: http://gerrit.cloudera.org:8080/11310
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/protobuf.gradle
1 file changed, 21 insertions(+), 2 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 7
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11310/5/java/gradle/protobuf.gradle
File java/gradle/protobuf.gradle:

http://gerrit.cloudera.org:8080/#/c/11310/5/java/gradle/protobuf.gradle@47
PS5, Line 47:          entries += new SourceFolder("${protobuf.generatedFilesBaseDir}/main/java"
Nit: You could use something like below. If you prefer the existing way, I am okay to submit as is. 

   def relPath = projectDir.toPath().relativize(file("${protobuf.generatedFilesBaseDir}/main/java").toPath())
   entries += new SourceFolder(relPath.toString(), null)



-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 5
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 25 Aug 2018 02:59:04 +0000
Gerrit-HasComments: Yes

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11310

to look at the new patch set (#2).

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Java projects
and allows to can run JUnit tests from Eclipse.

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 2
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 3: Verified+1

The failures are unrelated.


-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 24 Aug 2018 20:04:16 +0000
Gerrit-HasComments: No

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 3
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Greg Solovyev (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11310

to look at the new patch set (#6).

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................

Add protobuf generated files to Eclipse project classpath.

With this change Eclipse can compile all Kudu Java projects
and can run JUnit tests directly

Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
---
M java/gradle/protobuf.gradle
1 file changed, 21 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/10/11310/6
-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Add protobuf generated files to Eclipse project classpath.

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11310 )

Change subject: Add protobuf generated files to Eclipse project classpath.
......................................................................


Patch Set 6: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11310
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825002ce8436467cb9c32c0954f378e1959a5586
Gerrit-Change-Number: 11310
Gerrit-PatchSet: 6
Gerrit-Owner: Greg Solovyev <gs...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 27 Aug 2018 19:31:46 +0000
Gerrit-HasComments: No