You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/12 02:48:23 UTC
Review Request 60791: Add fetcher cache space usage metrics.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60791/
-----------------------------------------------------------
Review request for mesos.
Bugs: MESOS-7782
https://issues.apache.org/jira/browse/MESOS-7782
Repository: mesos
Description
-------
Add fetcher metrics to track the (constant) size of the cache size
and the (varying) amount of cache space use. The cache size is
published as `containerizer/fetcher/cache_size_total` and the used
space is `containerizer/fetcher/cache_size_used`. Both of these
metrics are in MB to be consistent with other disk space metrics.
Diffs
-----
docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12
src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f
src/slave/containerizer/fetcher_process.hpp 0a342303574927ebfb8c60e6ce2ebe67bd8a12a3
src/tests/fetcher_cache_tests.cpp 6e4736ea42430017ca6eff9134c1136179a4b26f
Diff: https://reviews.apache.org/r/60791/diff/1/
Testing
-------
make check (Fedora 26).
Thanks,
James Peach
Re: Review Request 60791: Add fetcher cache space usage metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60791/#review180492
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On July 12, 2017, 2:48 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60791/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 2:48 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7782
> https://issues.apache.org/jira/browse/MESOS-7782
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add fetcher metrics to track the (constant) size of the cache size
> and the (varying) amount of cache space use. The cache size is
> published as `containerizer/fetcher/cache_size_total` and the used
> space is `containerizer/fetcher/cache_size_used`. Both of these
> metrics are in MB to be consistent with other disk space metrics.
>
>
> Diffs
> -----
>
> docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12
> src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f
> src/slave/containerizer/fetcher_process.hpp 0a342303574927ebfb8c60e6ce2ebe67bd8a12a3
> src/tests/fetcher_cache_tests.cpp 6e4736ea42430017ca6eff9134c1136179a4b26f
>
>
> Diff: https://reviews.apache.org/r/60791/diff/2/
>
>
> Testing
> -------
>
> make check (Fedora 26).
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 60791: Add fetcher cache space usage metrics.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60791/#review180281
-----------------------------------------------------------
Bad review!
Reviews applied: []
Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.
- Mesos Reviewbot Windows
On July 12, 2017, 2:48 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60791/
> -----------------------------------------------------------
>
> (Updated July 12, 2017, 2:48 a.m.)
>
>
> Review request for mesos.
>
>
> Bugs: MESOS-7782
> https://issues.apache.org/jira/browse/MESOS-7782
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add fetcher metrics to track the (constant) size of the cache size
> and the (varying) amount of cache space use. The cache size is
> published as `containerizer/fetcher/cache_size_total` and the used
> space is `containerizer/fetcher/cache_size_used`. Both of these
> metrics are in MB to be consistent with other disk space metrics.
>
>
> Diffs
> -----
>
> docs/monitoring.md 38b8093ef683b5de65cbfa5330a6bbd1c9e10f12
> src/slave/containerizer/fetcher.cpp 6a664e0657a19d27afac98fd5298d6a18aabe43f
> src/slave/containerizer/fetcher_process.hpp 0a342303574927ebfb8c60e6ce2ebe67bd8a12a3
> src/tests/fetcher_cache_tests.cpp 6e4736ea42430017ca6eff9134c1136179a4b26f
>
>
> Diff: https://reviews.apache.org/r/60791/diff/1/
>
>
> Testing
> -------
>
> make check (Fedora 26).
>
>
> Thanks,
>
> James Peach
>
>