You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2013/03/15 14:59:20 UTC
Re: Review Request: Fix log4j configuration for KVM agent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9860/
-----------------------------------------------------------
(Updated March 15, 2013, 1:59 p.m.)
Review request for cloudstack and Chip Childers.
Description
-------
log4j in KVM is not initialized through main(), instead, the agent instance is initialized through invokation through java reflection. Initialize log4j in a proper place
Diffs
-----
Diff: https://reviews.apache.org/r/9860/diff/
Testing
-------
Manually tested in my local KVM environment
Thanks,
Kelven Yang
Re: Review Request: Fix log4j configuration for KVM agent
Posted by Chip Childers <ch...@sungard.com>.
On Fri, Mar 29, 2013 at 05:40:31AM +0000, Animesh Chaturvedi wrote:
>
>
> > On March 15, 2013, 1:59 p.m., Chip Childers wrote:
> > > also, what's the bug ID?
>
> I updated the BUG ID. Chip looking at JIRA you have already committed it. Kelven can you mark the patch as submitted?
>
>
> - Animesh
I just closed the review.
Re: Review Request: Fix log4j configuration for KVM agent
Posted by Animesh Chaturvedi <An...@citrix.com>.
> On March 15, 2013, 1:59 p.m., Chip Childers wrote:
> > also, what's the bug ID?
I updated the BUG ID. Chip looking at JIRA you have already committed it. Kelven can you mark the patch as submitted?
- Animesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9860/#review17976
-----------------------------------------------------------
On March 29, 2013, 5:39 a.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9860/
> -----------------------------------------------------------
>
> (Updated March 29, 2013, 5:39 a.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> log4j in KVM is not initialized through main(), instead, the agent instance is initialized through invokation through java reflection. Initialize log4j in a proper place
>
>
> This addresses bug CLOUDSTACK-1267.
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/9860/diff/
>
>
> Testing
> -------
>
> Manually tested in my local KVM environment
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Fix log4j configuration for KVM agent
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9860/#review17976
-----------------------------------------------------------
also, what's the bug ID?
- Chip Childers
On March 15, 2013, 1:59 p.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9860/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 1:59 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> log4j in KVM is not initialized through main(), instead, the agent instance is initialized through invokation through java reflection. Initialize log4j in a proper place
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/9860/diff/
>
>
> Testing
> -------
>
> Manually tested in my local KVM environment
>
>
> Thanks,
>
> Kelven Yang
>
>
Re: Review Request: Fix log4j configuration for KVM agent
Posted by Animesh Chaturvedi <An...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9860/
-----------------------------------------------------------
(Updated March 29, 2013, 5:39 a.m.)
Review request for cloudstack and Chip Childers.
Description
-------
log4j in KVM is not initialized through main(), instead, the agent instance is initialized through invokation through java reflection. Initialize log4j in a proper place
This addresses bug CLOUDSTACK-1267.
Diffs
-----
Diff: https://reviews.apache.org/r/9860/diff/
Testing
-------
Manually tested in my local KVM environment
Thanks,
Kelven Yang
Re: Review Request: Fix log4j configuration for KVM agent
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9860/#review17975
-----------------------------------------------------------
There was lots of back and forth about this topic. Is this patch still required?
- Chip Childers
On March 15, 2013, 1:59 p.m., Kelven Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9860/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 1:59 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> log4j in KVM is not initialized through main(), instead, the agent instance is initialized through invokation through java reflection. Initialize log4j in a proper place
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/9860/diff/
>
>
> Testing
> -------
>
> Manually tested in my local KVM environment
>
>
> Thanks,
>
> Kelven Yang
>
>