You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "LuciferYang (via GitHub)" <gi...@apache.org> on 2023/08/06 14:17:04 UTC
[GitHub] [spark] LuciferYang opened a new pull request, #42364: [SPARK-44690][BUILD] Downgrade Scala to 2.13.8
LuciferYang opened a new pull request, #42364:
URL: https://github.com/apache/spark/pull/42364
This reverts commit f21303fb17f969661da22e21e3c3687d4fe4c69a.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1667087120
Merged into master and branch-3.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang closed pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang closed pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
URL: https://github.com/apache/spark/pull/42364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1666878287
cc @HyukjinKwon @srowen we can use this one.
also cc @eejbyfeldt for more check.
Since Scala 2.13.11 is a blocker for the Scala 2.13 series to support Java 21, we will temporarily be unable to support Java-21ea version build and testing after this downgrade. also cc @dongjoon-hyun to know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669884074
Thank you, @LuciferYang .
Sorry for being late, but I have two minor questions for my understanding without further context except this PR.
- Given that it's reverted to Scala 2.13.8 from 2.13.11, do you happen to know the Scala issue about this?
- When we are going to drop Java 8 support in `master` for Apache Spark 4.0, do we still need this revert for `-target:jvm-1.8` on `master` branch? Or, does Scala 2.13.11 have any other issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669932710
Let me add two test scenarios:
1. Build with Java 11 and test with Java 17
3. Build with Java 17 and test with Java 21-ea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1666883685
It looks like it. It of course would be possible to create a custom build that evidently works on 21 with only minor changes (or are we really sure 2.13.8 + Java 21 doesn't work?) I think we have to make this trade if it's Java 8 support or 21 support; Java 8 support is a property on the 3.x line but 21 isn't even out yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669928077
@dongjoon-hyun
> Given that it's reverted to Scala 2.13.8 from 2.13.11, do you happen to know the Scala issue about this?
The main reason for the downgrade is that version 3.5 has not been released yet, and the master needs to maintain consistent behavior with previous versions. If there is a better way to solve this problem, we can upgrade again.
Sorry for overlooked this scenario during the last upgrade.
> When we are going to drop Java 8 support in master for Apache Spark 4.0, do we still need this revert for -target:jvm-1.8 on master branch? Or, does Scala 2.13.11 have any other issues?
My personal understanding is that we either accept the solution proposed in https://github.com/apache/spark/pull/41943: use `-target:${java.version}`, or we can find another solution to keep the `-target` as a fixed value, fFor example, modifying `scala-maven-plugin` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669930512
Thank you for the reply, @LuciferYang .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1667093813
Thanks @HyukjinKwon @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669927553
Yeah I think we always can hit this problem, if we want to make 1 release that works over N Java versions. I think the incompatibility issues are far smaller after Java 9.
However, the setup we are contemplating is to (for example) build with Java 11, not to build with 17 and target 11. That's not quite what you tested.
I personally think we should target Java 17 for Spark 4.0. Same problem is possible - does it run on 21? - but I think it's much less likely we face that, or we simply work around as we always did in the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669888159
There's a big discussion at https://github.com/apache/spark/pull/41943
I think we can update to Scala 2.13.11 again after we decide to drop Java 8 support. Then, the build targets Java 11 or 17 and we shouldn't face the same issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669947229
I don't think we'd ever maintain two binary releases built with different Java versions. So I think the scenario is always: build with minimum supported Java version, and test versus all supported versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1669908154
> There's a big discussion at #41943
>
> I think we can update to Scala 2.13.11 again after we decide to drop Java 8 support. Then, the build targets Java 11 or 17 and we shouldn't face the same issue.
@srowen You might have missed my previous comments: https://github.com/apache/spark/pull/41943#issuecomment-1662250764
I think even if we drop Java 8, like support Java 11+, we would still face this issue. It might be necessary to try to resolve this problem by `scala-maven-plugin` ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #42364: [SPARK-44690][SPARK-44376][BUILD] Downgrade Scala to 2.13.8
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #42364:
URL: https://github.com/apache/spark/pull/42364#issuecomment-1670760578
Just noticed that all of yesterday's subsequent comments were written here...
https://github.com/apache/spark/pull/42362#issuecomment-1670066795
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org