[jira] [Commented] (SOLR-7656) maxTotalChars param not respected in LangDetect language detection implementation

["Jan Høydahl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-7656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14581189#comment-14581189 ] 

Jan Høydahl commented on SOLR-7656:
-----------------------------------

Great, thanks for the contribution!

We try to have unit tests for all patches. Would you be able to extend your patch with a unit test that fails due to the bug before applying the patch?

> maxTotalChars param not respected in LangDetect language detection implementation
> ---------------------------------------------------------------------------------
>
>                 Key: SOLR-7656
>                 URL: https://issues.apache.org/jira/browse/SOLR-7656
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - LangId
>    Affects Versions: 5.2, Trunk
>            Reporter: Derek Wood
>            Priority: Minor
>         Attachments: SOLR-7656.patch
>
>
> The LangDetect wrapper code incorrectly uses the maxTotalChars param [1] to configure the max field length in the LangDetect library [2]
> [1] https://svn.apache.org/viewvc/lucene/dev/trunk/solr/contrib/langid/src/java/org/apache/solr/update/processor/LangDetectLanguageIdentifierUpdateProcessor.java?annotate=1643377#l51
> [2] https://github.com/shuyo/language-detection/blob/master/src/com/cybozu/labs/langdetect/Detector.java#L170



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org