[GitHub] [hudi] dongkelun commented on pull request #5633: [HUDI-4123] Fix the exception due to SqlSource return null checkpoint

[GitBox <gi...@apache.org>]

dongkelun commented on PR #5633:
URL: https://github.com/apache/hudi/pull/5633#issuecomment-1296412015

   > not sure what does checkpoint refer to incase of sql source. Incase of kafka, it refers to offset and while polling for msgs from kafka we honor that. incase of DFS based sources, checkpoint refers to last mod time of files and so we filter based on that while polling for new data. but can you help me understand what does checkpoint mean for sql sources. bcoz, we can allow configuring checkpoint, but as of now, we are not leveraging the checkpoint while querying from sql source. So, unless we fix that, I don't see much benefit in allowing users to configure checkpoint.
   
   Personally, I think it is useless to set checkpoint in `SqlSource` because it is meaningless


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org