You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2012/12/21 01:28:48 UTC
Review Request: SQOOP-799 Sqoop2: Change SqoopConnector interface to
abstract class
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8733/
-----------------------------------------------------------
Review request for Sqoop.
Description
-------
I've changed the implementation as proposed.
This addresses bug SQOOP-799.
https://issues.apache.org/jira/browse/SQOOP-799
Diffs
-----
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java ea92d0c
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java dc08675
Diff: https://reviews.apache.org/r/8733/diff/
Testing
-------
Unit tests seems to be passing.
Thanks,
Jarek Cecho
Re: Review Request: SQOOP-799 Sqoop2: Change SqoopConnector interface to
abstract class
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8733/#review14926
-----------------------------------------------------------
Ship it!
Ship It!
- Bilung Lee
On Dec. 21, 2012, 12:28 a.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8733/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2012, 12:28 a.m.)
>
>
> Review request for Sqoop.
>
>
> Description
> -------
>
> I've changed the implementation as proposed.
>
>
> This addresses bug SQOOP-799.
> https://issues.apache.org/jira/browse/SQOOP-799
>
>
> Diffs
> -----
>
> connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java ea92d0c
> spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java dc08675
>
> Diff: https://reviews.apache.org/r/8733/diff/
>
>
> Testing
> -------
>
> Unit tests seems to be passing.
>
>
> Thanks,
>
> Jarek Cecho
>
>