You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/06/24 22:54:50 UTC
[GitHub] [trafficcontrol] ocket8888 opened a new pull request #4830: Tm fix
ocket8888 opened a new pull request #4830:
URL: https://github.com/apache/trafficcontrol/pull/4830
## What does this PR (Pull Request) do?
- [x] This PR fixes #4825
## Which Traffic Control components are affected by this PR?
- Traffic Monitor
## What is the best way to verify this PR?
Run Traffic Monitor with some caches to poll, observe no error spam in the logs.
## If this is a bug fix, what versions of Traffic Control are affected?
- master
- 4.1
## The following criteria are ALL met by this PR
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4830: Traffic Monitor excessive log errors fix
Posted by GitBox <gi...@apache.org>.
ocket8888 commented on a change in pull request #4830:
URL: https://github.com/apache/trafficcontrol/pull/4830#discussion_r445875253
##########
File path: traffic_monitor/cache/astats.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/traffic_monitor/dsdata"
"github.com/apache/trafficcontrol/traffic_monitor/todata"
- "github.com/json-iterator/go"
+ jsoniter "github.com/json-iterator/go"
Review comment:
It wasn't, I didn't do it - at least not intentionally. I installed an IDE to help me wade through the confusing naming schemes of TM code, and I'd bet it did that for me automatically.
I can change it back if you want
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4830: Traffic Monitor excessive log errors fix
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #4830:
URL: https://github.com/apache/trafficcontrol/pull/4830#discussion_r445860342
##########
File path: traffic_monitor/cache/astats.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/traffic_monitor/dsdata"
"github.com/apache/trafficcontrol/traffic_monitor/todata"
- "github.com/json-iterator/go"
+ jsoniter "github.com/json-iterator/go"
Review comment:
Why is this necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #4830: Traffic Monitor excessive log errors fix
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #4830:
URL: https://github.com/apache/trafficcontrol/pull/4830#discussion_r445882958
##########
File path: traffic_monitor/cache/astats.go
##########
@@ -38,7 +38,7 @@ import (
"github.com/apache/trafficcontrol/lib/go-log"
"github.com/apache/trafficcontrol/traffic_monitor/dsdata"
"github.com/apache/trafficcontrol/traffic_monitor/todata"
- "github.com/json-iterator/go"
+ jsoniter "github.com/json-iterator/go"
Review comment:
Ok, it doesn't seem to be affecting anything but it doesn't appear to be used either, which is weird because Go won't let you compile with unused imports. I guess it must be `init`ing something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #4830: Traffic Monitor excessive log errors fix
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #4830:
URL: https://github.com/apache/trafficcontrol/pull/4830
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org