You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2025/04/27 08:07:48 UTC
[PR] Bump min Airflow version in providers to 2.10 [airflow]
eladkal opened a new pull request, #49843:
URL: https://github.com/apache/airflow/pull/49843
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #49843:
URL: https://github.com/apache/airflow/pull/49843#issuecomment-2833384103
> Looks good...
...except the one small static check... :-D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #49843:
URL: https://github.com/apache/airflow/pull/49843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #49843:
URL: https://github.com/apache/airflow/pull/49843#discussion_r2062533265
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -640,8 +640,7 @@ def get_airflow_extras():
PROVIDERS_COMPATIBILITY_TESTS_MATRIX: list[dict[str, str | list[str]]] = [
{
"python-version": "3.9",
- "airflow-version": "2.9.3",
- "remove-providers": "cloudant common.messaging fab edge3 git",
+ "airflow-version": "2.10.0",
"run-tests": "true",
},
Review Comment:
I think if we do not check compatability with 2.9 we do not need to check against 2.10.0 as well... as we cover this with 2.10.5 in the block below.
So I'd remove the Airflow 2.9 block w/o replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #49843:
URL: https://github.com/apache/airflow/pull/49843#issuecomment-2834350972
> > I didn't remove the references to AIRFLOW_V_2_10_PLUS as part of this PR.
> > we can do that after the release and specifically after we verify if we do 2.11 or not
>
> You can safely remove it now. It does not matter if we release 2.11 or not. If we decide to release 2.11, we should ADD `AIRFLOW_V_2_11_PLUS` as a constant - removal of `AIRFLOW_V_2_10_PLUS` is determined simply by the fact that `>=2.10` automatically means that everything is `AIRFLOW_V2_10_PLUS`, so all the code that is not in the if can be removed and the constant can be removed as well.
Will handle the removal separately in parallel. I want to move forward in merge so I can prepare changelogs.
This part is not automated yet so it takes long time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #49843:
URL: https://github.com/apache/airflow/pull/49843#issuecomment-2834377564
> Will handle the removal separately in parallel. I want to move forward in merge so I can prepare changelogs.
This part is not automated yet so it takes long time
Yep. Happy to help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #49843:
URL: https://github.com/apache/airflow/pull/49843#issuecomment-2833439075
> I didn't remove the references to AIRFLOW_V_2_10_PLUS as part of this PR.
we can do that after the release and specifically after we verify if we do 2.11 or not
You can safely remove it now. It does not matter if we release 2.11 or not. If we decide to release 2.11, we should ADD `AIRFLOW_V_2_11_PLUS` as a constant - removal of `AIRFLOW_V_2_10_PLUS` is determined simply by the fact that `>=2.10` automatically means that everything is `AIRFLOW_V2_10_PLUS`, so all the code that is not in the if can be removed and the constant can be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #49843:
URL: https://github.com/apache/airflow/pull/49843#discussion_r2062543031
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -640,8 +640,7 @@ def get_airflow_extras():
PROVIDERS_COMPATIBILITY_TESTS_MATRIX: list[dict[str, str | list[str]]] = [
{
"python-version": "3.9",
- "airflow-version": "2.9.3",
- "remove-providers": "cloudant common.messaging fab edge3 git",
+ "airflow-version": "2.10.0",
"run-tests": "true",
},
Review Comment:
I left it as 2.10 is no the same as 2.10.5
Not sure why the 2.10.5 was added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #49843:
URL: https://github.com/apache/airflow/pull/49843#discussion_r2062548060
##########
dev/breeze/src/airflow_breeze/global_constants.py:
##########
@@ -640,8 +640,7 @@ def get_airflow_extras():
PROVIDERS_COMPATIBILITY_TESTS_MATRIX: list[dict[str, str | list[str]]] = [
{
"python-version": "3.9",
- "airflow-version": "2.9.3",
- "remove-providers": "cloudant common.messaging fab edge3 git",
+ "airflow-version": "2.10.0",
"run-tests": "true",
},
Review Comment:
In the past the provider compatability tests were always made against the latest patch of each minor release. So when 2.10.5 was released we changed back-compat tests from 2.10.4 to 2.10.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bump min Airflow version in providers to 2.10 [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #49843:
URL: https://github.com/apache/airflow/pull/49843#discussion_r2062926773
##########
providers/microsoft/azure/tests/unit/microsoft/azure/hooks/test_msgraph.py:
##########
@@ -398,20 +398,22 @@ def test_handle_response_async_when_internal_server_error(self):
with pytest.raises(AirflowException):
asyncio.run(DefaultResponseHandler().handle_response_async(response, None))
- @pytest.mark.db_test
- def test_when_provider_min_airflow_version_is_2_10_or_higher_remove_obsolete_code(self):
- """
- Once this test starts failing due to the fact that the minimum Airflow version is now 2.10.0 or higher
- for this provider, you should remove the obsolete code in the get_proxies method of the
- KiotaRequestAdapterHook and remove this test. This test was added to make sure to not forget to
- remove the fallback code for backward compatibility with Airflow 2.9.x which isn't need anymore once
- this provider depends on Airflow 2.10.0 or higher.
- """
- min_airflow_version = get_provider_min_airflow_version("apache-airflow-providers-microsoft-azure")
-
- # Check if the current Airflow version is 2.10.0 or higher
- if min_airflow_version[0] >= 3 or (min_airflow_version[0] >= 2 and min_airflow_version[1] >= 10):
- method_source = inspect.getsource(KiotaRequestAdapterHook.get_proxies)
- raise AirflowProviderDeprecationWarning(
- f"Check TODO's to remove obsolete code in get_proxies method:\n\r\n\r\t\t\t{method_source}"
- )
+ # TODO: Elad: review this after merging the bump 2.10 PR
+ # We should not have specific provider test block the release
+ # @pytest.mark.db_test
+ # def test_when_provider_min_airflow_version_is_2_10_or_higher_remove_obsolete_code(self):
+ # """
+ # Once this test starts failing due to the fact that the minimum Airflow version is now 2.10.0 or higher
+ # for this provider, you should remove the obsolete code in the get_proxies method of the
+ # KiotaRequestAdapterHook and remove this test. This test was added to make sure to not forget to
+ # remove the fallback code for backward compatibility with Airflow 2.9.x which isn't need anymore once
+ # this provider depends on Airflow 2.10.0 or higher.
+ # """
+ # min_airflow_version = get_provider_min_airflow_version("apache-airflow-providers-microsoft-azure")
+ #
+ # # Check if the current Airflow version is 2.10.0 or higher
+ # if min_airflow_version[0] >= 3 or (min_airflow_version[0] >= 2 and min_airflow_version[1] >= 10):
+ # method_source = inspect.getsource(KiotaRequestAdapterHook.get_proxies)
+ # raise AirflowProviderDeprecationWarning(
+ # f"Check TODO's to remove obsolete code in get_proxies method:\n\r\n\r\t\t\t{method_source}"
+ # )
Review Comment:
Lets just mark as xfail instead with the todo?
##########
PROVIDERS.rst:
##########
@@ -145,6 +145,10 @@ classification, whether there are breaking changes, new features or just bugs co
Upgrading Minimum supported version of Airflow
----------------------------------------------
+.. note::
+
+ The following policy applies for Airflow 2. It has not yet been finalized for Airflow 3 and subject to changes.
Review Comment:
```suggestion
The following policy applies for Airflow 2. It has not yet been finalized for Airflow 3 and is subject to changes.
```
##########
PROVIDERS.rst:
##########
@@ -153,8 +157,8 @@ Airflow version to the next MINOR release, when 12 months passed since the first
MINOR version of Airflow.
For example this means that by default we upgrade the minimum version of Airflow supported by providers
-to 2.9.0 in the first Provider's release after 8th of April 2025. 8th of April 2024 is the date when the
-first ``PATCHLEVEL`` of 2.9 (2.9.0) has been released.
+to 3.0.0 in the first Provider's release after 22nd of April 2026. 22nd of April 2025 is the date when the
+first ``PATCHLEVEL`` of 3.0 (2.0.0) has been released.
Review Comment:
```suggestion
first ``MAJOR`` VERSION of 3.0 (3.0.0) was released.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org