You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by Apache Wiki <wi...@apache.org> on 2007/09/16 21:08:11 UTC

[Jakarta-jmeter Wiki] Update of "CommittingChanges" by JMeterAdmin

Dear Wiki user,

You have subscribed to a wiki page or wiki category on "Jakarta-jmeter Wiki" for change notification.

The following page has been changed by JMeterAdmin:
http://wiki.apache.org/jakarta-jmeter/CommittingChanges

------------------------------------------------------------------------------
  
  = Making changes =
   * Make the necessary code or documentation changes
+  * add or update unit tests
+  * perhaps update batchtest
  
  = Documenting changes =
-  * the xdocs/changes.xml file should be updated
+  * the xdocs/changes.xml file should be updated (except for trivial updates, e.g. correcting spelling in documentation)
  
  = Ant targets to run before committing =
   * ant package
   * ant test
-  * what else ? (I do not know)
+  * ant test-headless/test-headed (whichever was not run by the ant test)
  
  = Files to commit =
-  * Changes to files in the docs directory should not be committed, these files are built from xdocs. (Is this correct?)
+  * Changes to files in the docs directory need not be committed immediately. These files are built from xdocs.
-   * Only when release candidates are being made from the Subversion branch should the files in the docs directory be committed. (Is this correct?)
+   * When release candidates are being made from the Subversion branch the files in the docs directory must be committed. They can be committed earlier, but it saves on commits if they are batched up and done less frequently.
  
  = Committing to Subversion =
-  * Add a sensible description of your changes when committing to Subversion
+  * Add a sensible description of your changes when committing to Subversion (what is obvious now, may not be obvious in several months/year's time)
    * If you have fixed a Bugzilla entry, then include the Bugzilla number in the comment.
+   * SVN log entries can be changed later if you find the original message was not clear enough.
  
  = Updating Bugzilla entry =
-  * If you have fixed a Bugzilla entry, then set the status to ? ( I do not know what), and include the Subversion change number in the Bugzilla comment.
+  * If you have fixed a Bugzilla entry, then set the status to fixed, and include the Subversion change number in the Bugzilla comment. If there is some possibility that the fix is not complete, set the status to NeedInfo and ask the bug originator to confirm that the fix has been successful.
  

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org