You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ly...@apache.org on 2022/09/08 16:55:59 UTC

[superset] branch lyndsi/adddataset-act-cleanup created (now 276c42c542)

This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a change to branch lyndsi/adddataset-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git


      at 276c42c542 3 act errors removed from AddDataset test

This branch includes the following new commits:

     new 276c42c542 3 act errors removed from AddDataset test

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[superset] 01/01: 3 act errors removed from AddDataset test

Posted by ly...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

lyndsi pushed a commit to branch lyndsi/adddataset-act-cleanup
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 276c42c542eddf40eb1e97026457d424328890be
Author: lyndsiWilliams <kc...@gmail.com>
AuthorDate: Thu Sep 8 11:55:39 2022 -0500

    3 act errors removed from AddDataset test
---
 .../src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx         | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx
index cee1cea5e2..6a5bf1ea35 100644
--- a/superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx
+++ b/superset-frontend/src/views/CRUD/data/dataset/AddDataset/AddDataset.test.tsx
@@ -21,11 +21,12 @@ import { render, screen } from 'spec/helpers/testing-library';
 import AddDataset from 'src/views/CRUD/data/dataset/AddDataset';
 
 describe('AddDataset', () => {
-  it('renders a blank state AddDataset', () => {
+  it('renders a blank state AddDataset', async () => {
     render(<AddDataset />, { useRedux: true });
 
     const blankeStateImgs = screen.getAllByRole('img', { name: /empty/i });
 
+    expect(await screen.findByText(/header/i)).toBeInTheDocument();
     // Header
     expect(screen.getByText(/header/i)).toBeVisible();
     // Left panel