You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/08/27 04:59:47 UTC

[GitHub] [incubator-dolphinscheduler] geosmart opened a new pull request #3611: [FIX][UI]add button disabeld when isDetails

geosmart opened a new pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611


   with ONLINE process definition Add button should disabeld for readOnly


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] qiaozhanwei merged pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
qiaozhanwei merged pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681702198


   > but if disabled the `save` button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
   > so I just graying out the `add` button to avoid unnecessary click
   
   If the user needs to see the configuration information inside, it is also possible


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] geosmart commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
geosmart commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681646988


   > Is the save button in the gray toolbar more friendly
   
   after click `save` ,user have to config something before click `add` 
   ![image](https://user-images.githubusercontent.com/3156608/91408165-f7892780-e875-11ea-888e-1d837be414bb.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] geosmart commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
geosmart commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681681230


   > You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes
   
   but if disabled the `save` button , i can't check the config[tenant,alert,timeout]info in the popout dialog,
   so I just graying out the `add` button to avoid unnecessary click 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681667723


   You add this graying out for the work that is already online. The backend of the online workflow is checked. If you are only for the online workflow, you can prevent the user from clicking the save button and restrict the user from adding it. Can’t add some changes


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] break60 commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
break60 commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681554661


   Is the save button in the gray toolbar more friendly


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681499709


   Kudos, SonarCloud Quality Gate passed!
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=BUG)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/proje
 ct/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=SECURITY_HOTSPOT) to review)  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=3611&resolved=false&types=CODE_SMELL)
   
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3611&metric=coverage&view=list) No Coverage information  
   [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3611&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=3611&metric=new_duplicated_lines_density&view=list)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-dolphinscheduler] break60 edited a comment on pull request #3611: [FIX][UI]add button disabeld when isDetails

Posted by GitBox <gi...@apache.org>.
break60 edited a comment on pull request #3611:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3611#issuecomment-681554661


   Is the save button in the gray toolbar more friendly
   ![image](https://user-images.githubusercontent.com/55787491/91389041-1c2bd200-e86b-11ea-800b-4cb71aef8124.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org