You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2016/04/26 11:59:24 UTC

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

GitHub user tillrohrmann opened a pull request:

    https://github.com/apache/flink/pull/1931

    [FLINK-3741] [build] Replace maven-scala-plugin with newer scala-maven-plugin

    I've replaced the older {{maven-scala-plugin}} with the newer {{scala-maven-plugin}} and ran 10 Travis builds. So far none of them failed with the *Error: MissingRequirementError: object scala.runtime in compiler mirror not found.*

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tillrohrmann/flink fixScalaCompilation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1931.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1931
    
----
commit 6cb6179d919ad7fcfaec44f97630abcf2e07a0eb
Author: Till Rohrmann <tr...@apache.org>
Date:   2016-04-25T16:39:04Z

    [FLINK-3741] [build] Replace maven-scala-plugin with newer scala-maven-plugin

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/1931#issuecomment-214697826
  
    what about the other modules using scala; should we update them as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1931#issuecomment-214799876
  
    This PR does not solve the issue FLINK-3741.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:

    https://github.com/apache/flink/pull/1931#issuecomment-214790629
  
    The initial problem still persists :-( 
    
    Still, I would like to merge this PR to update the `scala-maven-plugin` using in Flink-ML.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann closed the pull request at:

    https://github.com/apache/flink/pull/1931


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3741] [build] Replace maven-scala-plugi...

Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:

    https://github.com/apache/flink/pull/1931#issuecomment-214714799
  
    @zentol only `flink-ml` used the outdated `maven-scale-plugin`, no idea why... 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---