[GitHub] [flink] swuferhong commented on pull request #21490: [FLINK-30368][table-planner] Fix calcite method RelMdUtil$numDistinctVals() wrongly return zero if the method input domainSize much larger than numSelected

[GitBox <gi...@apache.org>]

swuferhong commented on PR #21490:
URL: https://github.com/apache/flink/pull/21490#issuecomment-1347612522

   > Thanks for your contribution Could you please clarify how we can be sure that this change does what expected? May be some tests could be helpful to have.
   > 
   > Also it would be helpful to have info about what lines are changed in this class, like it is done e.g. in `RexSimplify`, `SqlToRelConverter` and other Calcite's classes
   > 
   > And another question: shouldn't this issue be raised in Calcite's jira?
   
   Hi, This bug was found in the `tpc-ds` benchmark tests. So it was difficult to reproduce in Flink ut test case, but I will try to reproduce it .
   
   OK, I will add more information in class annotation.
   
   I think it necessary to open a jira in calcite, and I will do it, Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org