You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/09/03 16:58:09 UTC
Re: Review Request 68236: Fixed
`LaunchNestedContainerSessionsInParallel` test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68236/
-----------------------------------------------------------
(Updated Sept. 3, 2018, 4:58 p.m.)
Review request for mesos and Alexander Rukletsov.
Summary (updated)
-----------------
Fixed `LaunchNestedContainerSessionsInParallel` test.
Bugs: MESOS-9116
https://issues.apache.org/jira/browse/MESOS-9116
Repository: mesos
Description (updated)
-------
Previously, we sent `ATTACH_CONTAINER_OUTPUT` to attach to a
short-living nested container. An attempt to attach to a terminated
nested container leads to HTTP 500 error. This patch gets rid of
`ATTACH_CONTAINER_OUTPUT` in favor of `LAUNCH_NESTED_CONTAINER_SESSION`
so that we can read the container's output without using an extra call.
Diffs (updated)
-----
src/tests/api_tests.cpp 43541af732df271177f0fd56ddc419adec461110
Diff: https://reviews.apache.org/r/68236/diff/1/
Testing (updated)
-------
1. sudo make check (Fedora 25)
2. internal CI
Thanks,
Andrei Budnik
Re: Review Request 68236: Fixed
`LaunchNestedContainerSessionsInParallel` test.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68236/#review208405
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Sept. 3, 2018, 4:58 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68236/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 4:58 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we sent `ATTACH_CONTAINER_OUTPUT` to attach to a
> short-living nested container. An attempt to attach to a terminated
> nested container leads to HTTP 500 error. This patch gets rid of
> `ATTACH_CONTAINER_OUTPUT` in favor of `LAUNCH_NESTED_CONTAINER_SESSION`
> so that we can read the container's output without using an extra call.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 43541af732df271177f0fd56ddc419adec461110
>
>
> Diff: https://reviews.apache.org/r/68236/diff/1/
>
>
> Testing
> -------
>
> 1. sudo make check (Fedora 25)
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 68236: Fixed
`LaunchNestedContainerSessionsInParallel` test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68236/#review208271
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68236']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2285/mesos-review-68236
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2285/mesos-review-68236/logs/mesos-tests.log):
```
I0903 19:12:09.363489 16652 executor.cpp:693] Forked command at 18864
I0903 19:12:09.393452 13808 exec.cpp:445] Executor asked to shutdown
I0903 19:12:09.394460 16652 executor.cpp:182] Received SHUTDOWN event
I0903 19:12:09.394460 16652 executor.cpp:796] Shutting down
I0903 19:12:09.394460 16652 executor.cpp:909] Sending SIGTERM to process tree at pid 18work 4b7da281-30de-4e12-985a-0e76719607d0-0000 on agent 4b7da281-30de-4e12-985a-0e76719607d0-S0 at slave(459)@192.10.1.11:60623 (windows-05.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0903 19:12:09.396457 10584 master.cpp:1251] Agent 4b7da281-30de-4e12-985a-0e76719607d0-S0 at slave(459)@192.10.1.11:60623 (windows-05.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected
I0903 19:12:09.396457 10584 master.cpp:3267] Disconnecting agent 4b7da281-30de-4e12-985a-0e76719607d0-S0 at slave(459)@192.10.1.11:60623 (windows-05.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0903 19:12:09.397449 10584 master.cpp:3286] Deactivating agent 4b7da281-30de-4e12-985a-0e76719607d0-S0 at slave(459)@192.10.1.11:60623 (windows-05.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
I0903 19:12:09.397449 7332 hierarchical.cpp:359] Removed framework 4b7da281-30de-4e12-985a-0e76719607d0-0000
I0903 19:12:09.397449 7332 hierarchical.cpp:795] Agent 4b7da281-30de-4e12-985a-0e76719607d0-S0 deactivated
I0903 19:[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (683 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (705 ms total)
[----------] Global test environment tear-down
[==========] 1048 tests from 103 test cases ran. (520727 ms total)
[ PASSED ] 1047 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
1 FAILED TEST
YOU HAVE 229 DISABLED TESTS
12:09.398437 4880 containerizer.cpp:2429] Destroying container 0fbba9eb-65d1-412f-abc1-1f6433e9d11e in RUNNING state
I0903 19:12:09.399446 4880 containerizer.cpp:3043] Transitioning the state of container 0fbba9eb-65d1-412f-abc1-1f6433e9d11e from RUNNING to DESTROYING
I0903 19:12:09.399446 4880 launcher.cpp:166] Asked to destroy container 0fbba9eb-65d1-412f-abc1-1f6433e9d11e
I0903 19:12:09.434448 7332 containerizer.cpp:2882] Container 0fbba9eb-65d1-412f-abc1-1f6433e9d11e has exited
I0903 19:12:09.466472 11828 master.cpp:1093] Master terminating
I0903 19:12:09.468454 4880 hierarchical.cpp:637] Removed agent 4b7da281-30de-4e12-985a-0e76719607d0-S0
I0903 19:12:09.780354 5796 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Sept. 3, 2018, 12:58 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68236/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2018, 12:58 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Bugs: MESOS-9116
> https://issues.apache.org/jira/browse/MESOS-9116
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, we sent `ATTACH_CONTAINER_OUTPUT` to attach to a
> short-living nested container. An attempt to attach to a terminated
> nested container leads to HTTP 500 error. This patch gets rid of
> `ATTACH_CONTAINER_OUTPUT` in favor of `LAUNCH_NESTED_CONTAINER_SESSION`
> so that we can read the container's output without using an extra call.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 43541af732df271177f0fd56ddc419adec461110
>
>
> Diff: https://reviews.apache.org/r/68236/diff/1/
>
>
> Testing
> -------
>
> 1. sudo make check (Fedora 25)
> 2. internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>