You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/04 12:40:20 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #1364: Remove .asm from .gitignore

xiaoxiang781216 opened a new pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364


   ## Summary
   since zipme.sh(with --exclude-vcs-ignores) fail to copy z80's assembler files(.asm).
   
   ## Impact
   
   ## Testing
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo closed pull request #1364: Remove .asm from .gitignore

Posted by GitBox <gi...@apache.org>.
patacongo closed pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1364: Remove .asm from .gitignore

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364#issuecomment-653773280


   This is not a good change and should not be merged.  All ZDS-II toolchain assembly files have the extension .asm but when you compile a .c file it generates a temporary .asm file that is then assembled.  When compile a foobar.c file with the ZDS-II toolchain, it generates foobar.asm, foobar.rel, foobar.obj, and foobar.lst. The .asm file is the only issue here because it is also the name used with all ZDS-II assembly file.
   
   So /.asm must appear in all ZDS-II build directories but cannot appear in a higher level directory. Just removing .asm from the top-level .gitignore file means that all of these .asm files (and there are hundreds) will all appear as untracked files. That makes those configurations very, very difficult to use.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] patacongo commented on pull request #1364: Remove .asm from .gitignore

Posted by GitBox <gi...@apache.org>.
patacongo commented on pull request #1364:
URL: https://github.com/apache/incubator-nuttx/pull/1364#issuecomment-653776820


   Replaced with PR #1367


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org