[jira] [Commented] (SOLR-16778) Skip check for local solr's running in bin/solr package

["Eric Pugh (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-16778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17749353#comment-17749353 ] 

Eric Pugh commented on SOLR-16778:
----------------------------------

I think what actually writes to a file is "DistribPackageStore._persistToFile"...    Since this is meant for SolrCloud...  Honestly, until we have an actual package that folks use, it's hard to know.  

> Skip check for local solr's running in bin/solr package 
> --------------------------------------------------------
>
>                 Key: SOLR-16778
>                 URL: https://issues.apache.org/jira/browse/SOLR-16778
>             Project: Solr
>          Issue Type: Sub-task
>          Components: cli
>    Affects Versions: main (10.0), 9.2
>            Reporter: Eric Pugh
>            Priority: Minor
>
> bin/solr package assumes you are running it on a local Solr box, it has a check that is super similar to the bin/solr status check for a local Solr node, and if it isn't running, then it exits.
> I'd like to remove that check, since we already have a bin/solr status, and let you install a package (assuming it's all API level) if you aren't on a local box.    I can imagine this for installing packages into a docker container for example..
> Here is the test bats test I would use:
> @test "outputting help without running solr" {
>   run solr package -help
>   assert_output --partial "Add a repository to Solr"
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org