You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/07 13:48:59 UTC
[GitHub] [netbeans] sdedic commented on a change in pull request #3717: java.lsp.server test improvements
sdedic commented on a change in pull request #3717:
URL: https://github.com/apache/netbeans/pull/3717#discussion_r820718770
##########
File path: java/java.lsp.server/test/unit/src/org/netbeans/modules/java/lsp/server/ConnectionSpecTest.java
##########
@@ -29,14 +29,18 @@
import org.junit.After;
import org.junit.Test;
import static org.junit.Assert.*;
+import org.netbeans.junit.NbTestCase;
+import org.netbeans.junit.RandomlyFails;
import org.openide.util.Pair;
-public class ConnectionSpecTest {
+@RandomlyFails
+public class ConnectionSpecTest extends NbTestCase {
private static ThreadLocal<List<Boolean>> copySessionServer = new ThreadLocal<>();
public ConnectionSpecTest() {
+ super(ConnectionSpecTest.class.getName());
Review comment:
Please change the constructor to `ConnectionSpecTest(String testName)` -- each testcase ought to have an unique name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists